-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] job testing coq-native #1504
base: master
Are you sure you want to change the base?
Conversation
b094f63
to
ff29817
Compare
@chdoc I'm trying to add a job here that warns (not fail) if a package is found to fail when coq-native is installed. |
@gares. Yes, you got the right package and for me it is still failing as of 5 minutes ago: https://github.com/coq-community/graph-theory/runs/1531187774 |
I think I found the problem. It's OCaml 4.05 + native. If you use an image based on ocaml 4.07 it works (even with native) |
Great! Thanks for the info! So the the world of |
It may also be related to the (default) stack size on docker... we are still investigating. |
84a27df
to
eb5c8c2
Compare
5dac11f
to
a1d8e0c
Compare
@ejgallego @erikmd I'm running out of ideas here. I'm trying to reproduce the failures that some users experienced using docker when the default image was including coq-native. I've added jobs to test things on 4.05, 4.07, 4.07+flambda, 4.09 and 4.09+flambda but I still have to see a single failure (even on gitlab's runners). I suppose I'm doing something wrong. It may be the configuration I'm testing (hence you in CC) or something else I miss. I had plans to have coqbot suggest a |
Hi @gares, thanks for your message and for your experiments. I don't have many clues, but at least, I'm able to reproduce the issue in GitHub Actions with the following workflow: test:
# the OS must be GNU/Linux to be able to use the docker-coq-action
runs-on: ubuntu-latest
strategy:
matrix:
image:
- 'coqorg/coq:dev-native-ocaml-4.07'
fail-fast: false
steps:
- uses: actions/checkout@v2
with:
repository: 'coq-community/graph-theory'
ref: 'ec5f2f3e37ed4485108796f6a35037ce1c6e270f'
- run: ls -Rhal
- uses: coq-community/docker-coq-action@v1
with:
opam_file: 'coq-graph-theory.opam'
custom_image: ${{ matrix.image }} so, using coq.dev and ocaml 4.07 (without flambda) + coq-native See the corresponding log: I don't know if this is due to the stack size as So to figure out which parameter could trigger this failure, I guess the next step would be to try to reproduce that build locally (outside of GitHub Actions). I'll try this tonight and let you know… |
The stack (outside docker) is 8K and the memory is 7 GB, which is better than what gitlab gives us. |
OK, so FYI @gares, the issue is reproducible locally.
|
BTW @gares you might want to edit your initial post to add something like this? |
Given that the error you managed to reproduce comes from our library, feel free to contact me if you think I can help. Admittedly, this is a somewhat ad-hoc corner of the library. 🤷♂️ |
@erikmd done thanks. I did some googling and you can pass to docker ulimit and ram caps on the command line, and I see none of these your entrypoint.sh. Maybe the defaults are just wrong? |
@chdoc I had a look to graph-theory and indeed it doesn't compile with coq-native and the usual 8 mB stack but increasing it to 10 mB seems to be enough (at least with OCaml 4.05, this might be more with other versions). So
within the docker image, before calling opam/make/... should suffice. |
Fix #1498