Fix npm warning by using configured default license #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikemaccana is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
We could probably use a CHANGELOG entry for this warning fix, could you add that?
mikemaccana
force-pushed
the
fix-missing-license-warning
branch
from
699d94a
to
30054c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a new project is made with
anchor init, runninganchor testwill display a warning because the package.json is missing thelicensefield:This PR uses the system's configured default license (ie, what
npm init -ywould use) to set the license for the new project.People can set their system's default license with
npm config set init-license "<license name>". Egnpm config set init-license "MIT"(if you prefer MIT to be the default)npm config set init-license "UNLICENSED"(if you do not wish to make your code open source)Note this is my first PR to a Rust project, so if you have any suggestions for the code please let me know!