Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GroupsAccumulator for ArrayAgg #229

Open
wants to merge 21 commits into
base: v37
Choose a base branch
from
Open

GroupsAccumulator for ArrayAgg #229

wants to merge 21 commits into from

Conversation

lkt
Copy link

@lkt lkt commented Apr 4, 2024 •
edited
Loading

thinkharderdev and others added 9 commits December 20, 2023 14:58
@thinkharderdev @Dandandan
Expose metrics from FileSinkExec impl of ExecutionPlan
98fbec6
@Dandandan
Add pool_size method to MemoryPool (#218)
cb3341f 
* Add pool_size method to MemoryPool

* Fix

* Fmt
@thinkharderdev
Handle hashing list of struct arrays
425247e
@jayzhan211 @thinkharderdev
Minor: Introduce utils::hash for StructArray (apache#8552)
cef9a84 
* hash struct

Signed-off-by: jayzhan211 <[email protected]>

* fmt

Signed-off-by: jayzhan211 <[email protected]>

* row-wise hash

Signed-off-by: jayzhan211 <[email protected]>

* fmt

Signed-off-by: jayzhan211 <[email protected]>

* create hashes once

Signed-off-by: jayzhan211 <[email protected]>

* cleanup

Signed-off-by: jayzhan211 <[email protected]>

* add comment

Signed-off-by: jayzhan211 <[email protected]>

---------

Signed-off-by: jayzhan211 <[email protected]>
@jayzhan211 @thinkharderdev
Minor: Fix incorrect indices for hashing struct (apache#8775)
f69abae 
* fix bug

Signed-off-by: jayzhan211 <[email protected]>

* fmt

Signed-off-by: jayzhan211 <[email protected]>

* add rowsort

Signed-off-by: jayzhan211 <[email protected]>

---------

Signed-off-by: jayzhan211 <[email protected]>
@thinkharderdev
Cherry-pick fixes for hashing Struct values
70797a4
@Dandandan
Fix ApproxPercentileAccumulator on zero values (apache#9582)
fce8bf8 
* Fix ApproxPercentileAccumulator

* Imports

* Use return type
@avantgardnerio
Support Union types in ScalarValue (apache#9683)
d88e414
@lkt
Proof of concept for GroupsAccumulator for ArrayAgg
b2225c4
@lkt lkt requested a review from Dandandan April 4, 2024 16:41
@lkt lkt requested review from joroKr21 and a team April 4, 2024 16:50
@lkt lkt marked this pull request as ready for review April 10, 2024 14:56
@github-actions github-actions bot added the core label Apr 12, 2024
@lkt lkt requested a review from joroKr21 April 12, 2024 12:24
joroKr21
joroKr21 reviewed Apr 12, 2024
View reviewed changes
datafusion/core/src/main.rs Outdated Show resolved Hide resolved
datafusion/physical-expr/src/aggregate/array_agg.rs Outdated Show resolved Hide resolved
datafusion/physical-expr/src/aggregate/array_agg.rs Outdated Show resolved Hide resolved
datafusion/physical-expr/src/aggregate/array_agg.rs Outdated Show resolved Hide resolved
datafusion/physical-expr/src/aggregate/array_agg.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the core label Apr 12, 2024
@lkt lkt requested a review from joroKr21 April 12, 2024 14:49
joroKr21
joroKr21 previously approved these changes Apr 12, 2024
View reviewed changes
@joroKr21 joroKr21 dismissed their stale review April 12, 2024 14:54

Doesn't compile

@lkt lkt changed the base branch from v34 to v37 April 12, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan left review comments

@joroKr21 joroKr21 joroKr21 left review comments

Assignees
No one assigned
Labels
physical-expr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lkt @Dandandan @joroKr21 @thinkharderdev @jayzhan211 @avantgardnerio