Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] removing reschedule on sucess #115

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

nicolastakashi
Copy link
Collaborator

We are removing the default enqueue on success because the controller runtime already synchronizes the watched resources every 10 hours by default. Therefore, forcing a reschedule upon successful reconciliation is unnecessary.

In the future, if needed, we can introduce a flag to adjust the sync period.

@nicolastakashi nicolastakashi requested a review from a team as a code owner July 17, 2024 08:16
@nicolastakashi nicolastakashi force-pushed the chore/removing-default-reschedule-time branch from 853d9c6 to 36052ea Compare July 17, 2024 09:41
Copy link

gitguardian bot commented Jul 17, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@nicolastakashi nicolastakashi force-pushed the chore/removing-default-reschedule-time branch from 36052ea to cc7b425 Compare July 17, 2024 09:42
Copy link
Contributor

github-actions bot commented Jul 23, 2024

Previous Coverage 11.0% of statements
New Coverage 11.0% of statements
Patch Coverage 69.2% of changed statements (9/13)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@nicolastakashi nicolastakashi force-pushed the chore/removing-default-reschedule-time branch from cc7b425 to c882f95 Compare July 23, 2024 10:10
OrNovo
OrNovo previously approved these changes Jul 28, 2024
@nicolastakashi nicolastakashi force-pushed the chore/removing-default-reschedule-time branch from c882f95 to ae4fa00 Compare July 29, 2024 08:57
@nicolastakashi nicolastakashi merged commit d832ea1 into main Jul 29, 2024
7 of 8 checks passed
@nicolastakashi nicolastakashi deleted the chore/removing-default-reschedule-time branch July 29, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants