Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PeerConnection.addStream|addTrack by using UUID().uuidString preffix for PluginMediaStream and PluginMediaStreamTrack only for Janus #467 #467

Merged
merged 4 commits into from
Feb 25, 2020

Conversation

hthetiot
Copy link
Contributor

use UUID().uuidString preffix for PluginMediaStream and PluginMediaStreamTrack only if rtcMediaStream.streamId or rtcMediaStreamTrack.trackId start with 'janus' to fix PeerConnection.addStream|addTrack regression

…reamTrack only if rtcMediaStream.streamId or rtcMediaStreamTrack.trackId start with 'janus' to fix PeerConnection.addStream|addTrack regression
…reamTrack only if rtcMediaStream.streamId or rtcMediaStreamTrack.trackId start with 'janus' to fix PeerConnection.addStream|addTrack regression
@hthetiot hthetiot added the bug label Feb 25, 2020
@hthetiot hthetiot self-assigned this Feb 25, 2020
@hthetiot hthetiot added this to the 6.0.8 milestone Feb 25, 2020
@hthetiot hthetiot merged commit 0070e49 into master Feb 25, 2020
@hthetiot hthetiot changed the title use UUID().uuidString preffix for PluginMediaStream and PluginMediaStreamTrack only for Janus Fix PeerConnection.addStream|addTrack by using UUID().uuidString preffix for PluginMediaStream and PluginMediaStreamTrack only for Janus #467 Feb 25, 2020
@hthetiot
Copy link
Contributor Author

Cause Janus still dont have unique StreamId and it sucks

@hthetiot
Copy link
Contributor Author

Look like that Janus is making progress on Unique Stream Id here:

@hthetiot
Copy link
Contributor Author

Note: @akilude I just saw your comment on janus-gateway#1880 I will release 6.0.8 (master) in less than 24 hours if you want to test iosrtc+janus when you have time, note that 7.0.0-RC1 M75 already include this PR also.

@hthetiot hthetiot deleted the bugs/addStream branch June 30, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant