Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Winget Releaser workflow & Dependabot #885

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Add Winget Releaser workflow & Dependabot #885

merged 1 commit into from
Jan 27, 2023

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Nov 19, 2022

This action automatically generates manifests for the Winget Community Repository (microsoft/winget-pkgs).

nvm-windows in Winget is outdated, and I have manually updated it for now (microsoft/winget-pkgs#89203). But once this is merged, automatic updates should automatically be deployed when you release a new version.

Before merging this:

  1. Add a PAT with public_repo scope as a repository secret named WINGET_TOKEN (or rename the secret name in the workflow).

example

  1. Fork https://github.com/microsoft/winget-pkgs under @coreybutler . The action will use that fork for making a branch and creating a PR with the upstream winget-pkgs repository on every release.
  2. Install Pull on the winget-pkgs fork to ensure that it is constantly updated.

The documentation and source code of the action is available here.

If you want to see an example of a PR created using this action, see microsoft/winget-pkgs/pulls (Pull request has been automatically created using 🛫 WinGet Releaser).

Copy link
Contributor

@veleek veleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just about to look into something like this!

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale Stale label Jan 19, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 19, 2023

@coreybutler Bump

@github-actions github-actions bot removed the Stale Stale label Jan 20, 2023
@coreybutler coreybutler merged commit 32df552 into coreybutler:master Jan 27, 2023
@sitiom sitiom deleted the winget-releaser branch January 27, 2023 03:28
@coreybutler
Copy link
Owner

Alright, we're going to give this a shot. There will be a new minor release sometime in the next week, so we'll see how it goes.

@sitiom
Copy link
Contributor Author

sitiom commented Apr 13, 2023

@coreybutler Can you rerun the failed workflow in https://github.com/coreybutler/nvm-windows/actions/runs/4685243965/jobs/8302161400?

Edit: nvm-setup.exe doesn't exist. Please add that first then rerun the workflow.

@coreybutler
Copy link
Owner

@sitiom I think the action ran before the assets were fully uploaded. nvm-setup.exe was included when I cut the release. However; it looks like the process is expecting a URL. I don't know where this would be configured or what the value should be. https://github.com/coreybutler/nvm-windows/actions/runs/4685243965/jobs/8302254488#step:2:93

@sitiom
Copy link
Contributor Author

sitiom commented Apr 13, 2023

@sitiom I think the action ran before the assets were fully uploaded. nvm-setup.exe was included when I cut the release.

This is the case. The action is expecting for an nvm-setup.exe asset. However, I still don't see the nvm-setup.exe asset in the releases. Was it really included?

https://github.com/coreybutler/nvm-windows/releases/tag/1.1.11

@coreybutler
Copy link
Owner

@sitiom - my mistake, I read that as nvm-setup.zip, which does exist.

@sitiom
Copy link
Contributor Author

sitiom commented Apr 13, 2023

Can you try to rerun the workflow again? The latest error is unusual 🤔. Maybe the token is invalid?

@sitiom
Copy link
Contributor Author

sitiom commented Apr 13, 2023

@sitiom
Copy link
Contributor Author

sitiom commented Apr 15, 2023

Manually created the PR for now: microsoft/winget-pkgs#102565 (comment)

@coreybutler
Copy link
Owner

@sitiom The URL it is complaining about only exists in the README of the repo, for a "sponsor" (which happens to be one of my firms). I know the link is valid, but I'm not sure why the README would be picked up at all.

@sitiom
Copy link
Contributor Author

sitiom commented Apr 16, 2023

I think it took the first link from your GitHub profile as the PublisherUrl.

@cfreear
Copy link

cfreear commented May 19, 2023

I think it took the first link from your GitHub profile as the PublisherUrl.

This is it, the tool that the github action uses takes the "website" field from your github profile and uses it as the publisher URL :/

https://github.com/russellbanks/Komac/blob/2d92db680c29ee43a2a6c085d8a34ec36dd736c4/src/main/kotlin/detection/github/GitHubDetection.kt#L62

@coreybutler
Copy link
Owner

Well that's annoying. Metadoc (the linked page) is one of my other ventures, unrelated to NVM4W.

@cfreear
Copy link

cfreear commented Jul 14, 2023

Komac (the tool used by this action) now prioritises the repo homepage over the owner's website field for the publisher url, adding the repo page url (https://github.com/coreybutler/nvm-windows) to the about section might now fix this.

@rickgoemans
Copy link

Any progress on this? Winget still has 1.1.10 instead of 1.1.12

@sitiom
Copy link
Contributor Author

sitiom commented Dec 5, 2023

Any progress on this? Winget still has 1.1.10 instead of 1.1.12

#1066 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Package for Winget
5 participants