allow to run build.bat on paths with spaces #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harald Fassler <[email protected]>
|
This PR is stale because it has been open 45 days with no activity. |
|
While this great change is not implemented I've fix this setting the environment variable with my bear hand! type 'path' in the windows logo and open the window for change env variables and add the download node version under the "C:\Users\Corporate User With Damn Spaces\AppData\Roaming\nvm\v18.16.1" to your path with your hand using the long way obviously (right click and go to the copy option in the box after selected the path on the Windows Explorer, then in the window ... you know what, you probably know the rest.) |
|
This PR is stale because it has been open 45 days with no activity. |
coreybutler
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to test #965 I also needed those changes