Skip to content

Commit

Permalink
Update mpi4py_cluster.py
Browse files Browse the repository at this point in the history
Further clean up unneeded comments.
  • Loading branch information
coreyjadams committed Jun 27, 2024
1 parent 6cc07a9 commit ef3a2e2
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions jax/_src/clusters/mpi4py_cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,7 @@ class Mpi4pyCluster(clusters.ClusterEnv):

@classmethod
def is_env_present(cls) -> bool:
# Why include and opt_in? Enables this class to conform to
# every other ClusterEnv subclass while always being rejected
# as viable, except in the express case where we request to check
# it explicitly.

# in many HPC clusters, the variables `https_proxy` and `http_proxy`
# are set to enable access to normally unreachable network locations.
# For example, `pip install ...` fails on compute nodes without them.

# Unfortunately, these variables break the jax distributed init.
# The user needs to unset them, but I don't want to modify the global
# python os.environ here for them (bad practice)

# And I also don't know what the right way to raise a complaint here is

# Relies on mpi4py:
return find_spec("mpi4py") is not None

Expand Down Expand Up @@ -76,7 +62,6 @@ def get_coordinator_address(cls, timeout_secs: int | None) -> str:

# Broadcast the host_ip to all ranks:
hostname = COMM_WORLD.bcast(hostname, root=0)
# host_ip = COMM_WORLD.bcast(host_ip, root=0)


return hostname
Expand Down

0 comments on commit ef3a2e2

Please sign in to comment.