Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transforms] FoldBitWidth pass to fix cornell-zhang/allo#121 #213

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matth2k
Copy link

@matth2k matth2k commented Jan 23, 2024

I wrote this pass with cornell-zhang/allo#121 in mind. However, it still needs testing and to be integrated within the Allo compilation pipeline. It probably has some bugs still.

@chhzh123 any feedback? Where should this pass get called in Allo? Should we expose it to Python or just bundle the pass in with some other lowering step?

@matth2k matth2k requested a review from chhzh123 January 23, 2024 06:24
@chhzh123
Copy link
Member

Probably it would be better to make it an option for now. You can expose the pass to the Python frontend.

I can take a closer look once you provide some test cases or examples, but currently the pass looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants