Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update access modifier "public Methode()" #1588

Merged
merged 2 commits into from
Jan 18, 2024
Merged

update access modifier "public Methode()" #1588

merged 2 commits into from
Jan 18, 2024

Conversation

Bertk
Copy link
Collaborator

@Bertk Bertk commented Jan 17, 2024 •
edited
Loading

related #1583

@Bertk Bertk changed the title update access modifier public Methode() update access modifier "public Methode()" Jan 17, 2024
@Bertk Bertk added the bug Something isn't working label Jan 17, 2024
@daveMueller
Copy link
Collaborator

A bit annoying that we need to change the access modifier but I also think this is currently the best solution. 👍

@Bertk Bertk marked this pull request as ready for review January 18, 2024 05:11
@MarcoRossignoli MarcoRossignoli merged commit 9295fca into coverlet-coverage:master Jan 18, 2024
8 checks passed
@Bertk Bertk deleted the issue-1583-2 branch January 18, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveMueller daveMueller daveMueller approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bertk @daveMueller @MarcoRossignoli