display multiple custom fields in operator view

[alex-Arc]

implements #991

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (9)

• apps/client/src/common/components/view-params-editor/ParamInput.tsx is excluded by none and included by none
• apps/client/src/common/components/view-params-editor/constants.ts is excluded by none and included by none
• apps/client/src/common/components/view-params-editor/types.ts is excluded by none and included by none
• apps/client/src/features/operator/Operator.tsx is excluded by none and included by none
• apps/client/src/features/operator/edit-modal/EditModal.tsx is excluded by none and included by none
• apps/client/src/features/operator/operator-event/OperatorEvent.module.scss is excluded by none and included by none
• apps/client/src/features/operator/operator-event/OperatorEvent.tsx is excluded by none and included by none
• apps/client/src/features/viewers/common/viewUtils.ts is excluded by none and included by none
• pnpm-lock.yaml is excluded by !pnpm-lock.yaml and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[alex-Arc]

@cpvalente I could use some help with the styling

[cpvalente]

Hi @alex-Arc , just finish what you can and I can do the styling.
would you mind adding a screenshot highlighting the issue?

[alex-Arc]

I have gotten as far as i can. It works as before,
it's mainly just getting it to look like the other fileds

[alex-Arc]

@cpvalente I tried again to get the theming to work, but no luck
https://v2.chakra-ui.com/docs/components/menu/usage

I would like it to look somewhat like the select element or at least be the same colour

[cpvalente]

I think this looks OK.

It seems a bit annoying that the multi select menu does not keep between versions.

1. open the menu and multi-select some stuff
2. press save and marvel
3. open the menu again and change another setting
4. press save and see all your multi-select is gone

Can we also have a sanity check for performance?
Since subscriptions is no longer a string, we lost our stable reference

We could split the ontime event block for some fewer calculations around mapping around subscriptions, but dealing with objects makes things less performant and more complex

[alex-Arc]

i fixed the disappearing values when editing again
but they still disappear when looking at the dropdown twice

Recording.2024-06-09.221542.mp4

I think be course we don't have any where to keep the string array
Should I add one more useRef for this or a useState?

[cpvalente]

I think be course we don't have any where to keep the string array

Should I add one more useRef for this or a useState?

To have a piece of data which causes re-renders you need usaste-te

[alex-Arc]

I needed a useEffect to make it stable is this ok ?
@cpvalente
01cf0b0

should I make the other types into components as well?

[cpvalente]

I needed a useEffect to make it stable is this ok ? @cpvalente 01cf0b0

you usually dont need to combine both the useEffect and a useState
would the following not work?

  const [paramState, setParamState] = useState<string>(setParamState(defaultOptionValue));

should I make the other types into components as well?

I would be of the opinion that things that are "as well" are generally out of scope. For now lets focus on merging this feature and keep the improvements in mind

[cpvalente]

Works well and code looks good, good work