-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display multiple custom fields in operator view #1001
Conversation
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (9)
You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@cpvalente I could use some help with the styling |
Hi @alex-Arc , just finish what you can and I can do the styling. |
@cpvalente I tried again to get the theming to work, but no luck I would like it to look somewhat like the select element or at least be the same colour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks OK.
It seems a bit annoying that the multi select menu does not keep between versions.
- open the menu and multi-select some stuff
- press save and marvel
- open the menu again and change another setting
- press save and see all your multi-select is gone
Can we also have a sanity check for performance?
Since subscriptions is no longer a string, we lost our stable reference
We could split the ontime event block for some fewer calculations around mapping around subscriptions, but dealing with objects makes things less performant and more complex
c21eb1d
to
ca7b7bc
Compare
apps/client/src/features/operator/operator-event/OperatorEvent.tsx
Outdated
Show resolved
Hide resolved
i fixed the disappearing values when editing again Recording.2024-06-09.221542.mp4I think be course we don't have any where to keep the string array |
To have a piece of data which causes re-renders you need usaste-te |
I needed a useEffect to make it stable is this ok ? should I make the other types into components as well? |
you usually dont need to combine both the const [paramState, setParamState] = useState<string>(setParamState(defaultOptionValue));
I would be of the opinion that things that are "as well" are generally out of scope. For now lets focus on merging this feature and keep the improvements in mind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well and code looks good, good work
implements #991