-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract parseUserTime #1005
Conversation
Important Review SkippedReview was skipped due to path filters Files ignored due to path filters (13)
You can disable this status message by setting the Tip Early Access Features
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing stands out to me here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most functionality seams preserved
This now somewhat parses thep+30
syntax during import and p+30
will become 00:30:00
before there is no reference to what came before p
is always 0
dont know it that is a good or bad thing
also it seams to accept a lot of stuff after the number
15whatever
-> 15:00:00
but
5whatever
-> 00:00:00
This PR extracts the recent logic for parsing time strings in frontend to be shared in server and UI.
This means that in Excel, we use the same parsing of time strings as we do in the UI inputs
There arent many changes otherwise, but
Number()
instead ofparseInt()
so that it will fail if the string is not a parseable numberNote for reviewer:
The first commit is where the large change is, which is just moving things from one package to another and can be ignored
The change itself is pretty minimal