Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow time change from api #1009

Merged
merged 15 commits into from
Jun 2, 2024
Merged

Allow time change from api #1009

merged 15 commits into from
Jun 2, 2024

Conversation

alex-Arc
Copy link
Collaborator

@alex-Arc alex-Arc commented May 27, 2024

#1017 is fixed and sending a time to the change API that is outside the allowed range will no longer be corrected just dropped

closes #970
allowed properties for change API is now:

  • title
  • note
  • cue
  • isPublic
  • skip
  • colour
  • custom
  • timeWarning
  • timeDanger
  • endAction
  • timerType
  • duration
  • timeStart
  • timeEnd

skip, duration, timeStart, timeEnd is throttled to 1 call per 20ms

the behaviour is:

  • msg 1 <-- applied
  • msg 2
  • msg 3
  • msg 4 <-- timeout reached <-- applied
  • mgs 5
  • msg 6
  • msg 7
  • (nothing sendt from user)
  • (nothing sendt from user)
  • (nothing sendt from user)
  • (nothing sendt from user) <-- timeout reached <-- msg 7 applied

@alex-Arc alex-Arc linked an issue May 27, 2024 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented May 27, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (6)
  • apps/server/src/api-integration/integration.controller.ts is excluded by none and included by none
  • apps/server/src/api-integration/integration.utils.ts is excluded by none and included by none
  • apps/server/src/services/rundown-service/rundownCacheUtils.ts is excluded by none and included by none
  • apps/server/src/utils/__tests__/coerceType.test.ts is excluded by none and included by none
  • apps/server/src/utils/coerceType.ts is excluded by none and included by none
  • apps/server/src/utils/throttle.ts is excluded by none and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alex-Arc alex-Arc requested a review from cpvalente May 27, 2024 19:42
@cpvalente cpvalente changed the title Allow time chage from api Allow time change from api May 30, 2024
Copy link
Collaborator

@jwetzell jwetzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing sticks out to me!

@alex-Arc alex-Arc requested a review from cpvalente May 31, 2024 14:46
Copy link
Owner

@cpvalente cpvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. lets try this

@alex-Arc alex-Arc merged commit 3895b37 into master Jun 2, 2024
3 checks passed
@alex-Arc alex-Arc deleted the allow-time-chage-from-api branch June 2, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Whitelist allow changing end time of event
3 participants