-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct key on shortcuts #1018
Conversation
Important Review SkippedReview was skipped due to path filters Files ignored due to path filters (2)
You can disable this status message by setting the Tip Early Access Features
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Personally, I prefer the symbols to the words However, it seems like the old code was perhaps using the incorrect glyph for the shift key, which is why it looked particularly confusing with the arrows. Up arrow should be |
@lukestein I have tried using the shift key but the symbols seemed very similar to me What do you think? |
@@ -3,6 +3,6 @@ export function isMacOS() { | |||
return userAgent.includes('macintosh') || userAgent.includes('mac os'); | |||
} | |||
|
|||
export const deviceAlt = isMacOS() ? '⌥' : 'Alt'; | |||
export const deviceAlt = 'Alt'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const deviceAlt = isMacOS() ? 'Option' : 'Alt';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mac refers to Alt key as "Option"
I have decided to spell out the keys rather than having symbols. I believe this makes it clearer even it it is more noisy (maybe)
@lukestein what do you think?