Countdown #1124
Countdown #1124
Conversation
WalkthroughThe recent updates introduce enhancements to the Changes
Sequence DiagramsOperator Options CreationsequenceDiagram
participant UI as User Interface
participant OpOpt as operator.options.tsx
participant Utils as Utilities
UI->>+OpOpt: Request operator options (customFields, timeFormat)
OpOpt->>+Utils: Get clock options
OpOpt-->>UI: Return operator options
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/types/src/definitions/runtime/Runtime.type.tsis excluded by none and included by none
Files selected for processing (18)
- apps/client/src/common/components/view-params-editor/constants.ts (1 hunks)
- apps/client/src/features/viewers/ViewWrapper.tsx (4 hunks)
- apps/client/src/features/viewers/countdown/Countdown.scss (6 hunks)
- apps/client/src/features/viewers/countdown/Countdown.tsx (5 hunks)
- apps/client/src/features/viewers/countdown/countdown.helpers.ts (2 hunks)
- apps/client/src/features/viewers/public/Public.scss (1 hunks)
- apps/client/src/theme/_viewerDefs.scss (1 hunks)
- apps/client/src/translation/languages/de.ts (1 hunks)
- apps/client/src/translation/languages/en.ts (1 hunks)
- apps/client/src/translation/languages/es.ts (1 hunks)
- apps/client/src/translation/languages/fr.ts (1 hunks)
- apps/client/src/translation/languages/it.ts (1 hunks)
- apps/client/src/translation/languages/no.ts (1 hunks)
- apps/client/src/translation/languages/pl.ts (2 hunks)
- apps/client/src/translation/languages/pt.ts (1 hunks)
- apps/client/src/translation/languages/sv.ts (1 hunks)
- apps/server/src/services/timerUtils.ts (1 hunks)
- apps/server/src/stores/runtimeState.ts (2 hunks)
Files skipped from review due to trivial changes (2)
- apps/client/src/features/viewers/public/Public.scss
- apps/client/src/theme/_viewerDefs.scss
Additional comments not posted (40)
apps/client/src/translation/languages/no.ts (1)
9-12: Translation keys added for scheduled and projected times.The new keys
common.scheduled_start,common.scheduled_end,common.projected_start, andcommon.projected_endhave been added correctly. Ensure that these keys are used consistently across the application.apps/client/src/translation/languages/en.ts (1)
7-10: Translation keys added for scheduled and projected times.The new keys
common.scheduled_start,common.scheduled_end,common.projected_start, andcommon.projected_endhave been added correctly. Ensure that these keys are used consistently across the application.apps/client/src/translation/languages/sv.ts (1)
9-12: Translation keys added for scheduled and projected times.The new keys
common.scheduled_start,common.scheduled_end,common.projected_start, andcommon.projected_endhave been added correctly. Ensure that these keys are used consistently across the application.apps/client/src/translation/languages/fr.ts (1)
9-12: Translation keys added for scheduled and projected times.The new keys
common.scheduled_start,common.scheduled_end,common.projected_start, andcommon.projected_endhave been added correctly. Ensure that these keys are used consistently across the application.apps/client/src/translation/languages/pl.ts (1)
9-12: Translation keys added correctly.The new translation keys for scheduled and projected times have been added correctly and the translations appear accurate.
apps/client/src/translation/languages/it.ts (1)
9-12: Translation keys added correctly.The new translation keys for scheduled and projected times have been added correctly and the translations appear accurate.
apps/client/src/translation/languages/pt.ts (1)
9-12: Translation keys added correctly.The new translation keys for scheduled and projected times have been added correctly and the translations appear accurate.
apps/client/src/translation/languages/es.ts (1)
9-12: Translation keys added correctly.The new translation keys for scheduled and projected times have been added correctly and the translations appear accurate.
apps/client/src/translation/languages/de.ts (1)
9-12: Translation keys look good.The new translation keys for scheduling and projected times are correctly translated.
apps/client/src/features/viewers/countdown/countdown.helpers.ts (6)
27-34: Ensure correct usage of theoffsetparameter.The
offsetparameter is correctly used to adjust the timer values if theshowProjectedflag is true. No issues found.
37-42: Verify the logic for projected times.The logic for adjusting the timer values based on the
showProjectedflag andoffsetparameter is correct. Ensure that theoffsetparameter is passed correctly when calling this function.
52-66: Ensure correct handling of timers spanning multiple days.The logic for handling timers that span multiple days is correct. The
offsetparameter is used appropriately to adjust the timer values.
72-80: Handle null values for start and end times.The function correctly handles cases where the start and end times are null. No issues found.
82-94: Ensure correct usage of theoffsetparameter.The
offsetparameter is correctly used to adjust the timer values if theshowProjectedflag is true. No issues found.
99-102: Ensure URL parameter is correctly parsed.The function correctly parses the
showProjectedparameter from the URL and returns a boolean value. No issues found.apps/client/src/features/viewers/ViewWrapper.tsx (2)
40-40: Property addition looks good.The
runtimeproperty has been correctly added to theWithDataPropstype.
71-71: Ensure correct usage of theruntimeproperty.The
runtimeproperty is correctly passed and used in the component. No issues found.apps/client/src/features/viewers/countdown/Countdown.scss (13)
24-24: Font size adjustment looks good.The font size for the event title is adjusted using the
clampfunction, which ensures responsiveness. No issues found.
28-28: Font size adjustment looks good.The font size for the event list is adjusted using the
clampfunction, which ensures responsiveness. No issues found.
41-42: Layout adjustment looks good.The gap and padding for the countdown container are adjusted using the
minandclampfunctions, which ensure responsiveness. No issues found.
48-52: Grid layout adjustment looks good.The grid layout for the countdown container is defined using
grid-template-areas, which improves readability and maintainability. No issues found.
62-62: Font size adjustment looks good.The font size for the clock label is set using a variable, which ensures consistency. No issues found.
68-68: Font size adjustment looks good.The font size for the clock value is set using a variable, which ensures consistency. No issues found.
78-78: Font size adjustment looks good.The font size for the status text is adjusted using the
clampfunction, which ensures responsiveness. No issues found.
108-108: Padding adjustment looks good.The padding for the title is adjusted, which improves the spacing and readability. No issues found.
122-132: Grid layout for timer group looks good.The grid layout for the timer group is defined using
grid-template-areas, which improves readability and maintainability. No issues found.
134-140: Grid areas for projected times look good.The grid areas for the projected start and end times are correctly defined. No issues found.
142-148: Grid areas for scheduled times look good.The grid areas for the scheduled start and end times are correctly defined. No issues found.
150-154: Font size and color adjustments look good.The font size and color for the timer labels are set using variables, which ensures consistency. No issues found.
156-164: Font size and color adjustments look good.The font size and color for the timer values are set using variables, which ensures consistency. No issues found.
apps/client/src/features/viewers/countdown/Countdown.tsx (6)
3-11: Import statement changes approved.The import statements have been correctly updated to include the
Runtimetype.
32-36: CountdownProps interface changes approved.The
CountdownPropsinterface has been correctly updated to include theruntimeproperty.
40-40: Countdown function destructuring changes approved.The
Countdownfunction has been correctly updated to destructure theruntimeproperty.
83-86: useEffect dependency array changes approved.The
useEffectdependency array has been correctly updated to includeruntime.offset.
99-104: getTimerItems function call changes approved.The
getTimerItemsfunction call has been correctly updated to includeruntime.offset.
138-149: Projected time display changes approved.The code has been correctly updated to display projected start and end times.
apps/server/src/services/timerUtils.ts (1)
302-305: getRuntimeOffset function changes approved.The
getRuntimeOffsetfunction has been correctly updated to return0instead ofnullwhen there are no loaded events or the timer has not started.apps/client/src/common/components/view-params-editor/constants.ts (1)
511-521: getCountdownOptions function changes approved.The
getCountdownOptionsfunction has been correctly updated to include an option for showing projected time.apps/server/src/stores/runtimeState.ts (2)
22-22: initialRuntime changes approved.The
initialRuntimeobject has been correctly updated to initializeoffsetto0instead ofnull.
85-85: clear function changes approved.The
clearfunction has been correctly updated to resetoffsetto0instead ofnull.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/types/src/definitions/runtime/Runtime.type.tsis excluded by none and included by none
Files selected for processing (20)
- apps/client/src/common/components/view-params-editor/constants.ts (1 hunks)
- apps/client/src/features/viewers/ViewWrapper.tsx (4 hunks)
- apps/client/src/features/viewers/countdown/Countdown.scss (6 hunks)
- apps/client/src/features/viewers/countdown/Countdown.tsx (5 hunks)
- apps/client/src/features/viewers/countdown/countdown.helpers.ts (2 hunks)
- apps/client/src/features/viewers/public/Public.scss (1 hunks)
- apps/client/src/theme/_viewerDefs.scss (1 hunks)
- apps/client/src/translation/languages/de.ts (1 hunks)
- apps/client/src/translation/languages/en.ts (1 hunks)
- apps/client/src/translation/languages/es.ts (1 hunks)
- apps/client/src/translation/languages/fr.ts (1 hunks)
- apps/client/src/translation/languages/it.ts (1 hunks)
- apps/client/src/translation/languages/no.ts (1 hunks)
- apps/client/src/translation/languages/pl.ts (2 hunks)
- apps/client/src/translation/languages/pt.ts (1 hunks)
- apps/client/src/translation/languages/sv.ts (1 hunks)
- apps/server/src/services/tests/timerUtils.test.ts (1 hunks)
- apps/server/src/services/timerUtils.ts (1 hunks)
- apps/server/src/stores/tests/runtimeState.test.ts (1 hunks)
- apps/server/src/stores/runtimeState.ts (2 hunks)
Files skipped from review due to trivial changes (4)
- apps/client/src/translation/languages/es.ts
- apps/server/src/services/tests/timerUtils.test.ts
- apps/server/src/stores/tests/runtimeState.test.ts
- apps/server/src/stores/runtimeState.ts
Files skipped from review as they are similar to previous changes (14)
- apps/client/src/common/components/view-params-editor/constants.ts
- apps/client/src/features/viewers/ViewWrapper.tsx
- apps/client/src/features/viewers/countdown/Countdown.scss
- apps/client/src/features/viewers/countdown/countdown.helpers.ts
- apps/client/src/features/viewers/public/Public.scss
- apps/client/src/theme/_viewerDefs.scss
- apps/client/src/translation/languages/en.ts
- apps/client/src/translation/languages/fr.ts
- apps/client/src/translation/languages/it.ts
- apps/client/src/translation/languages/no.ts
- apps/client/src/translation/languages/pl.ts
- apps/client/src/translation/languages/pt.ts
- apps/client/src/translation/languages/sv.ts
- apps/server/src/services/timerUtils.ts
Additional comments not posted (11)
apps/client/src/translation/languages/de.ts (4)
9-9: Translation key added:common.scheduled_startThe translation for "Scheduled Start" seems appropriate and accurate.
10-10: Translation key added:common.scheduled_endThe translation for "Scheduled End" seems appropriate and accurate.
11-11: Translation key added:common.projected_startThe translation for "Projected Start" seems appropriate and accurate.
12-12: Translation key added:common.projected_endThe translation for "Projected End" seems appropriate and accurate.
apps/client/src/features/viewers/countdown/Countdown.tsx (7)
3-3: New imports addedThe new imports for
Runtimeand functions fromcountdown.helpers.tsare necessary for the new functionality and appear to be correctly added.Also applies to: 24-25
32-36: UpdatedCountdownPropsinterfaceThe addition of the
runtimeproperty to theCountdownPropsinterface is necessary for managing the offsets and projected times.
40-40: UpdatedCountdownfunction parametersThe inclusion of
runtimein theCountdownfunction's parameters and destructuring is necessary for the new functionality.
86-86: UpdateduseEffectdependency arrayThe inclusion of
runtime.offsetin theuseEffectdependency array ensures that the effect runs whenever the offset changes.
99-104: New code block for projected timesThe new code block correctly handles the display of projected start and end times when they are available.
138-149: New code blocks for projected times displayThe new code blocks correctly handle the display of projected start and end times when they are available.
150-156: New code blocks for scheduled times displayThe new code blocks correctly handle the display of scheduled start and end times.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/client/src/features/viewers/countdown/Countdown.tsx (5 hunks)
- apps/client/src/features/viewers/countdown/countdown.helpers.ts (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- apps/client/src/features/viewers/countdown/Countdown.tsx
- apps/client/src/features/viewers/countdown/countdown.helpers.ts
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (23)
- apps/client/src/common/components/view-params-editor/ParamInput.tsx (1 hunks)
- apps/client/src/common/components/view-params-editor/ViewParamsEditor.module.scss (1 hunks)
- apps/client/src/common/components/view-params-editor/ViewParamsEditor.tsx (4 hunks)
- apps/client/src/common/components/view-params-editor/constants.ts (2 hunks)
- apps/client/src/common/components/view-params-editor/types.ts (2 hunks)
- apps/client/src/features/operator/Operator.tsx (3 hunks)
- apps/client/src/features/operator/operator.options.tsx (1 hunks)
- apps/client/src/features/viewers/backstage/Backstage.tsx (3 hunks)
- apps/client/src/features/viewers/backstage/backstage.options.ts (1 hunks)
- apps/client/src/features/viewers/clock/Clock.tsx (3 hunks)
- apps/client/src/features/viewers/clock/clock.options.ts (1 hunks)
- apps/client/src/features/viewers/countdown/Countdown.tsx (5 hunks)
- apps/client/src/features/viewers/countdown/countdown.options.ts (1 hunks)
- apps/client/src/features/viewers/lower-thirds/LowerThird.tsx (2 hunks)
- apps/client/src/features/viewers/lower-thirds/lowerThird.options.ts (1 hunks)
- apps/client/src/features/viewers/minimal-timer/MinimalTimer.tsx (3 hunks)
- apps/client/src/features/viewers/minimal-timer/minimalTimer.options.ts (1 hunks)
- apps/client/src/features/viewers/public/Public.tsx (3 hunks)
- apps/client/src/features/viewers/public/public.options.ts (1 hunks)
- apps/client/src/features/viewers/studio/StudioClock.tsx (3 hunks)
- apps/client/src/features/viewers/studio/studioClock.options.ts (1 hunks)
- apps/client/src/features/viewers/timer/Timer.tsx (3 hunks)
- apps/client/src/features/viewers/timer/timer.options.ts (1 hunks)
Files skipped from review due to trivial changes (2)
- apps/client/src/common/components/view-params-editor/ParamInput.tsx
- apps/client/src/features/operator/Operator.tsx
Files skipped from review as they are similar to previous changes (1)
- apps/client/src/features/viewers/countdown/Countdown.tsx
Additional context used
Biome
apps/client/src/common/components/view-params-editor/constants.ts
[error] 7-7: Avoid the use of spread (
...) syntax on accumulators.Spread syntax should be avoided on accumulators (like those in
.reduce) because it causes a time complexity ofO(n^2).
Consider methods such as .splice or .push instead.(lint/performance/noAccumulatingSpread)
apps/client/src/features/operator/operator.options.tsx
[error] 10-10: Avoid the use of spread (
...) syntax on accumulators.Spread syntax should be avoided on accumulators (like those in
.reduce) because it causes a time complexity ofO(n^2).
Consider methods such as .splice or .push instead.(lint/performance/noAccumulatingSpread)
Additional comments not posted (64)
apps/client/src/features/viewers/studio/studioClock.options.ts (2)
1-2: Imports look good.The imports are necessary for the functionality provided in this file.
4-9: FunctiongetStudioClockOptionsis well-structured.The function correctly returns an array of
ViewOptionobjects with sections and options.apps/client/src/common/components/view-params-editor/ViewParamsEditor.module.scss (3)
16-16: Consistent use of spacing.The
gapproperty ensures consistent spacing between elements in.label.
19-26: New styles for.sectionlook good.The styles for
.sectionensure proper spacing and font size. The use ofmargin-topfor non-first children is a good practice.
28-33: New styles for.fieldSetare appropriate.The styles for
.fieldSetensure proper layout and spacing. The use ofmargin-leftis consistent with the design.apps/client/src/features/viewers/countdown/countdown.options.ts (3)
1-2: Imports look good.The imports are necessary for the functionality provided in this file.
4-12: FunctionmakePersistedFieldis well-implemented.The function correctly creates a
ViewOptionobject for persisted fields.
14-29: FunctiongetCountdownOptionsis comprehensive.The function correctly generates countdown options, including the new "Show projected time" option and persisted fields.
apps/client/src/common/components/view-params-editor/types.ts (4)
1-3: TypeParamSectionis well-defined.The type correctly defines a section with a string property.
26-27: TypePersistedFieldis well-defined.The type correctly defines a persisted field with necessary properties.
28-30: TypeParamFieldis comprehensive.The type correctly combines various field types, including the new
PersistedField.
32-37: FunctionisSectionis well-implemented.The function correctly performs type assertion for
ParamSection.apps/client/src/common/components/view-params-editor/constants.ts (4)
3-3: Import statement forParamField.The import statement for
ParamFieldis necessary for the new type definitions.
Line range hint
12-21:
Well-structured function for time format options.The
getTimeOptionfunction is well-structured and provides a clear configuration for time format options.Tools
Biome
[error] 7-7: Avoid the use of spread (
...) syntax on accumulators.Spread syntax should be avoided on accumulators (like those in
.reduce) because it causes a time complexity ofO(n^2).
Consider methods such as .splice or .push instead.(lint/performance/noAccumulatingSpread)
23-29: Useful configuration for hiding seconds in the timer.The
hideTimerSecondsconstant is appropriately defined and provides a useful configuration option.
31-37: Useful configuration for showing leading zeros in the timer.The
showLeadingZerosconstant is appropriately defined and provides a useful configuration option.apps/client/src/features/viewers/public/public.options.ts (2)
1-4: Necessary import statements.The import statements for
CustomFields,getTimeOption,makeOptionsFromCustomFields, andViewOptionare necessary for the functionality provided in the file.
6-44: Well-structured function for generating public viewer options.The
getPublicOptionsfunction is well-structured and provides a clear set of options for the public viewer.apps/client/src/features/viewers/backstage/backstage.options.ts (2)
1-4: Necessary import statements.The import statements for
CustomFields,getTimeOption,makeOptionsFromCustomFields, andViewOptionare necessary for the functionality provided in the file.
6-44: Well-structured function for generating backstage viewer options.The
getBackstageOptionsfunction is well-structured and provides a clear set of options for the backstage viewer.apps/client/src/features/operator/operator.options.tsx (2)
1-4: Necessary import statements.The import statements for
CustomFields,getTimeOption,makeOptionsFromCustomFields, andViewOptionare necessary for the functionality provided in the file.
13-56: Well-structured function for generating operator viewer options.The rest of the
getOperatorOptionsfunction is well-structured and provides a useful set of options for the operator viewer.apps/client/src/features/viewers/timer/timer.options.ts (7)
1-10: Imports look good.The necessary types and utility functions are correctly imported.
11-13: Function signature and options generation look good.The function parameters and the generation of
mainOptionsandsecondaryOptionsare logical and correct.
15-16: Clock Options section looks good.The
getTimeOptionfunction is correctly used to include time format options.
17-19: Timer Options section looks good.The
hideTimerSecondsandshowLeadingZerosoptions are correctly included and logically grouped.
20-36: Data sources section looks good.The options for selecting data sources for main and secondary text are correctly included and logically grouped.
37-72: Element visibility section looks good.The options for hiding various elements are correctly included and logically grouped.
14-73: Overall structure and content of the returned array look good.All sections and options are correctly included and logically grouped.
apps/client/src/features/viewers/clock/clock.options.ts (5)
1-2: Imports look good.The necessary types and utility functions are correctly imported.
4-4: Function signature looks good.The function parameter and return type are logical and correct.
5-6: Clock Options section looks good.The
getTimeOptionfunction is correctly used to include time format options.
7-75: View style override section looks good.The options for customizing the clock's appearance are correctly included and logically grouped.
4-76: Overall structure and content of the returned array look good.All sections and options are correctly included and logically grouped.
apps/client/src/features/viewers/minimal-timer/minimalTimer.options.ts (5)
1-2: Imports look good.The necessary types and utility functions are correctly imported.
5-6: Timer Options section looks good.The
hideTimerSecondsoption is correctly included and logically grouped.
7-21: Element visibility section looks good.The options for hiding various elements are correctly included and logically grouped.
22-90: View style override section looks good.The options for customizing the timer's appearance are correctly included and logically grouped.
4-91: Overall structure and content of the array look good.All sections and options are correctly included and logically grouped.
apps/client/src/features/viewers/lower-thirds/lowerThird.options.ts (6)
1-4: Imports look good.The necessary types and utility functions are correctly imported.
6-14: Function signature and options generation look good.The function parameter and the generation of
topSourceOptionsandbottomSourceOptionsare logical and correct.
17-28: View behaviour section looks good.The
Animation Triggeroption is correctly included and logically grouped.
29-45: Data sources section looks good.The options for selecting data sources for top and bottom text are correctly included and logically grouped.
46-130: View style override section looks good.The options for customizing the lower third's appearance are correctly included and logically grouped.
16-131: Overall structure and content of the returned array look good.All sections and options are correctly included and logically grouped.
apps/client/src/common/components/view-params-editor/ViewParamsEditor.tsx (5)
16-16: ImportingisSectionandViewOptionThe import of
isSectionandViewOptionfromtypesis correct and aligns with the new structure.
25-47: ModifyinggetURLSearchParamsFromObjThe function now correctly handles
ViewOptionobjects, including extracting persisted values. Ensure that allViewOptionobjects are correctly handled.
51-51: AddingviewOptionstoEditFormDrawerPropsThis change is consistent with the new data structure. Ensure all references to
paramFieldsare updated.
Line range hint
54-82:
UsingviewOptionsinViewParamsEditorThe component now uses
viewOptions. The logic for handling form submission and resetting parameters is sound. Ensure all instances ofparamFieldsare replaced.
99-121: RenderingviewOptionsThe rendering logic handles sections and persistent types correctly. Ensure all
ViewOptiontypes are considered.apps/client/src/features/viewers/clock/Clock.tsx (2)
13-14: ImportinggetClockOptionsThe import of
getClockOptionsaligns with the new structure for clock options.
134-134: UsingViewParamsEditorwithclockOptionsThe
ViewParamsEditorcomponent is correctly provided withclockOptions. EnsureclockOptionsis correctly formed.apps/client/src/features/viewers/public/Public.tsx (2)
21-22: ImportinggetPublicOptionsThe import of
getPublicOptionsaligns with the new structure for public view options.
77-77: UsingViewParamsEditorwithpublicOptionsThe
ViewParamsEditorcomponent is correctly provided withpublicOptions. EnsurepublicOptionsis correctly formed.apps/client/src/features/viewers/studio/StudioClock.tsx (2)
16-17: ImportinggetStudioClockOptionsandstudioClock.utilsThe import of
getStudioClockOptionsandstudioClock.utilsaligns with the new structure for studio clock options.
78-78: UsingViewParamsEditorwithstudioClockOptionsThe
ViewParamsEditorcomponent is correctly provided withstudioClockOptions. EnsurestudioClockOptionsis correctly formed.apps/client/src/features/viewers/minimal-timer/MinimalTimer.tsx (2)
13-14: Import ofMINIMAL_TIMER_OPTIONSlooks good.The import statement follows standard practices and integrates well within the file.
165-165: Usage ofMINIMAL_TIMER_OPTIONSinViewParamsEditorlooks correct.The
MINIMAL_TIMER_OPTIONSis appropriately passed as a prop to theViewParamsEditorcomponent.apps/client/src/features/viewers/lower-thirds/LowerThird.tsx (2)
11-12: Import ofgetLowerThirdOptionslooks good.The import statement follows standard practices and integrates well within the file.
186-186: Usage ofgetLowerThirdOptionsinViewParamsEditorlooks correct.The
getLowerThirdOptionsis appropriately passed as a prop to theViewParamsEditorcomponent.apps/client/src/features/viewers/backstage/Backstage.tsx (2)
25-26: Import ofgetBackstageOptionslooks good.The import statement follows standard practices and integrates well within the file.
103-103: Usage ofgetBackstageOptionsinViewParamsEditorlooks correct.The
getBackstageOptionsis appropriately passed as a prop to theViewParamsEditorcomponent.apps/client/src/features/viewers/timer/Timer.tsx (2)
27-28: Import ofgetTimerOptionslooks good.The import statement follows standard practices and integrates well within the file.
162-162: Usage ofgetTimerOptionsinViewParamsEditorlooks correct.The
getTimerOptionsis appropriately passed as a prop to theViewParamsEditorcomponent.
apps/client/src/common/components/view-params-editor/constants.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/client/src/common/components/view-params-editor/constants.ts (2 hunks)
- apps/client/src/features/operator/operator.options.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- apps/client/src/common/components/view-params-editor/constants.ts
- apps/client/src/features/operator/operator.options.tsx
This PR adds the ability to show projected times in the countdown
I have also cleaned up the effects to allow users to clear the selection by refreshing the page
Partially implements #1007
The part described as Kitchen view is not implemented and should be extracted to a new ticket
Note to reviewer:
There are a lot of changes here, mostly in code organisation and style.
We just need to assert that applying the setting shows the offset times