Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade node dependencies #1130

Merged
merged 1 commit into from
Jul 11, 2024
Merged

chore: upgrade node dependencies #1130

merged 1 commit into from
Jul 11, 2024

Conversation

cpvalente
Copy link
Owner

@cpvalente cpvalente commented Jul 10, 2024

This upgrades a bunch of dependencies related to node

node upgraded to 20
electron upgraded to 31
pnpm upgraded to 9

Also managed to remove nodemon and ts-node in favour of tsx which just worked out of the box 🤩

Note to reviewers:
Not much to review here, it is just a normal dependency upgrade
Just keep an eye out for something that looks strange, mostly the PR is a warning "update your tooling or your setups wont work"

Copy link
Contributor

coderabbitai bot commented Jul 10, 2024

Warning

Rate limit exceeded

@cpvalente has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 44 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 07f6f60 and 8a8ce14.

Walkthrough

The recent changes involve updating the types of interval-related properties from NodeJS.Timer to NodeJS.Timeout across several service files. This modification ensures type consistency and correctness within the codebase, accommodating the more accurate NodeJS.Timeout type for timer-related functionalities.

Changes

Files Change Summary
apps/server/src/services/TimerService.ts Updated _interval and endCallback types from NodeJS.Timer to NodeJS.Timeout.
apps/server/src/services/aux-timer-service/AuxTimerService.ts Changed interval type from NodeJS.Timer | null to NodeJS.Timeout | null.
apps/server/src/services/sheet-service/SheetService.ts Modified pollInterval type from NodeJS.Timer | null to NodeJS.Timeout | null.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cpvalente cpvalente force-pushed the upgrade-node-deps branch 3 times, most recently from 86d79b2 to 07f6f60 Compare July 10, 2024 12:28
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e90e948 and 07f6f60.

Files ignored due to path filters (10)
  • .github/workflows/build.yml is excluded by none and included by none
  • .github/workflows/build_cli.yml is excluded by none and included by none
  • .github/workflows/test.yml is excluded by none and included by none
  • .nvmrc is excluded by none and included by none
  • DEVELOPMENT.md is excluded by none and included by none
  • Dockerfile is excluded by none and included by none
  • apps/electron/package.json is excluded by none and included by none
  • apps/server/package.json is excluded by none and included by none
  • package.json is excluded by none and included by none
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml and included by none
Files selected for processing (3)
  • apps/server/src/services/TimerService.ts (1 hunks)
  • apps/server/src/services/aux-timer-service/AuxTimerService.ts (1 hunks)
  • apps/server/src/services/sheet-service/SheetService.ts (1 hunks)
Files skipped from review due to trivial changes (3)
  • apps/server/src/services/TimerService.ts
  • apps/server/src/services/aux-timer-service/AuxTimerService.ts
  • apps/server/src/services/sheet-service/SheetService.ts

@cpvalente cpvalente merged commit 4758bc8 into master Jul 11, 2024
3 checks passed
@cpvalente cpvalente deleted the upgrade-node-deps branch July 11, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant