Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch Dockerfile build stage to non-alpine image #1134

Merged
merged 2 commits into from
Jul 14, 2024
Merged

Conversation

jwetzell
Copy link
Collaborator

Seems to be some known issue with alpine images and node >= 20 this is breaking the docker builder stage. This switches the builder stage to a debian based node image. I have tested this is working now with multi-platform builds.

Copy link
Contributor

coderabbitai bot commented Jul 13, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • Dockerfile is excluded by none and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jwetzell jwetzell requested a review from cpvalente July 13, 2024 02:28
Copy link
Owner

@cpvalente cpvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still unclear to me what are we gaining with corepack.

Does it mean we don't need to have NPM as a dependency?
Can we make our bundle somehow smaller with taking advantage of this? Or maybe it doesn't actually do anything and we could disable it?

Either way, this change looks good, let's try it!
Thank you for looking into it

@jwetzell
Copy link
Collaborator Author

@cpvalente I tried keeping the builder image on -alpine image and switching the pnpm install method to npm install -g [email protected] and that still hung things up so it wasn't specific to corepack and alpine. It's node >=20 and alpine in general it seems. I do like the npm install method as it's easier to specify a version so I'll switch it to that here.

@cpvalente
Copy link
Owner

@cpvalente I tried keeping the builder image on -alpine image and switching the pnpm install method to npm install -g [email protected] and that still hung things up so it wasn't specific to corepack and alpine. It's node >=20 and alpine in general it seems. I do like the npm install method as it's easier to specify a version so I'll switch it to that here.

Sounds good. Let's try and merge and make a new beta release to test it out. Are you able to do that?

@jwetzell jwetzell merged commit 91f21fd into master Jul 14, 2024
3 checks passed
@jwetzell jwetzell deleted the fix/docker-building branch July 14, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants