-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch Dockerfile build stage to non-alpine image #1134
Conversation
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (1)
You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still unclear to me what are we gaining with corepack.
Does it mean we don't need to have NPM as a dependency?
Can we make our bundle somehow smaller with taking advantage of this? Or maybe it doesn't actually do anything and we could disable it?
Either way, this change looks good, let's try it!
Thank you for looking into it
@cpvalente I tried keeping the builder image on |
Sounds good. Let's try and merge and make a new beta release to test it out. Are you able to do that? |
Seems to be some known issue with alpine images and node >= 20 this is breaking the docker builder stage. This switches the builder stage to a debian based node image. I have tested this is working now with multi-platform builds.