-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore rundownGetAll #1162
restore rundownGetAll #1162
Conversation
WalkthroughThe recent changes enhance the server API by introducing a new asynchronous function, Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Router
participant Controller
Client->>Router: GET /
Router->>Controller: rundownGetAll()
Controller-->>Router: JSON (OntimeRundown)
Router-->>Client: Response (All Rundowns)
sequenceDiagram
participant Client
participant Router
participant Controller
Client->>Router: GET /paginated
Router->>Controller: rundownGetPaginated()
Controller-->>Router: JSON (Paginated Rundowns)
Router-->>Client: Response (Paginated Data)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/server/src/api-data/rundown/rundown.controller.ts (2 hunks)
- apps/server/src/api-data/rundown/rundown.router.ts (2 hunks)
Additional comments not posted (4)
apps/server/src/api-data/rundown/rundown.router.ts (2)
9-9
: Import statement forrundownGetAll
looks good.The import statement is correct and necessary for the new functionality.
33-34
: Routing logic changes are correct.The root path now correctly uses
rundownGetAll
and the new route for paginated results is added as intended.apps/server/src/api-data/rundown/rundown.controller.ts (2)
4-4
: Import statement forOntimeRundown
looks good.The import statement is correct and necessary for the new functionality.
32-35
: FunctionrundownGetAll
implementation looks good.The function correctly retrieves all rundown entries and sends the response in JSON format. Error handling is not required here as the function is straightforward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
ip:port/data/rundown
-> array with rundownip:port/data/rundown/paginated?offset=0&limit=10
-> object with rundown section and total event number