-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getShouldClockUpdate test #1165
Conversation
WalkthroughThe recent changes enhance the test suite for the Changes
Sequence Diagram(s)sequenceDiagram
participant Test Suite
participant Timer
participant getShouldClockUpdate
Test Suite->>Timer: Setup fake timers
Timer-->>Test Suite: Timers controlled
Test Suite->>getShouldClockUpdate: Call with previousUpdate and now
getShouldClockUpdate-->>Test Suite: Return clock update decision
Test Suite->>Timer: Cleanup timers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/server/src/services/runtime-service/tests/rundownService.utils.test.ts (2 hunks)
Additional comments not posted (6)
apps/server/src/services/runtime-service/__tests__/rundownService.utils.test.ts (6)
4-7
: LGTM! ThebeforeEach
hook is correctly setting up the test environment.The fake timers and system time initialization ensure consistent test conditions.
9-11
: LGTM! TheafterEach
hook is correctly restoring the test environment.Restoring the real timers ensures proper cleanup after each test.
15-16
: LGTM! The test case correctly simulates sliding forwards.Setting
previousUpdate
to the current time andnow
to 2000 milliseconds in the future ensures accurate evaluation of thegetShouldClockUpdate
function.
22-23
: LGTM! The test case correctly simulates sliding backwards.Setting
previousUpdate
to 2000 milliseconds in the future andnow
to the current time ensures accurate evaluation of thegetShouldClockUpdate
function.
36-37
: LGTM! The test case correctly simulates the clock being a second ahead.Setting
previousUpdate
toMILLIS_PER_MINUTE - 100
andnow
toMILLIS_PER_MINUTE
ensures accurate evaluation of thegetShouldClockUpdate
function.
36-37
: LGTM! The test case correctly simulates the clock not being a second ahead.Setting
previousUpdate
to the current time andnow
to 32 milliseconds in the future ensures accurate evaluation of thegetShouldClockUpdate
function.
It seams that using system time in github actions tests is unstable
and values from Date.now() should never be less than zero