-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client remote control #930
Conversation
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (33)
You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
fe63730
to
8e0879e
Compare
apps/client/src/features/app-settings/panel/client-control-panel/ClientList.tsx
Outdated
Show resolved
Hide resolved
apps/client/src/common/components/identify-overlay/IdentifyOverlay.tsx
Outdated
Show resolved
Hide resolved
apps/client/src/common/components/identify-overlay/IdentifyOverlay.tsx
Outdated
Show resolved
Hide resolved
@jwetzell if you could give this feature a try that would be very welcome i find it easiest to test by open one window to |
I don't really know what is being added. I did pull this branch and run it. If I open 2 tabs (one in incognito) I see 2 entries in |
Thank you, that's it Any comments on the UI or the like? was it somewhat intuitive? |
Seems to be, I didn't immediately understand what redirect would do but simple enough to just try it out |
apps/client/src/common/components/client-modal/RedirectClientModal.tsx
Outdated
Show resolved
Hide resolved
apps/client/src/common/components/client-modal/RenameClientModal.tsx
Outdated
Show resolved
Hide resolved
apps/client/src/common/components/client-modal/RenameClientModal.tsx
Outdated
Show resolved
Hide resolved
apps/client/src/features/app-settings/panel/client-control-panel/ClientList.tsx
Outdated
Show resolved
Hide resolved
apps/client/src/common/components/navigation-menu/NavigationMenu.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Valente <[email protected]>
@alex-Arc ![]() |
yeah name and path are unknown at start up |
…e/ontime into client-remote-control-2
#781 continued here
TODO