Add option to display the full time (HH:mm:ss) in the timer view

[thelan]

Hello,

Its just a small patch to add an view option to enable the timer to display the full-clock instead of being hardcoded to remove leading zeros.

Let me know if i need to change or optimize things

[coderabbitai]

Important

Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (3)

• apps/client/src/common/components/view-params-editor/constants.ts is excluded by none and included by none
• apps/client/src/features/viewers/common/viewUtils.ts is excluded by none and included by none
• apps/client/src/features/viewers/timer/Timer.tsx is excluded by none and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cpvalente]

Thank you!

The change itself looks good to me, but I am a bit confused with the setup.
Maybe I misunderstood something?

[thelan]

Ok so i fixed the typos, also inverted the logic to keep the default setting as it use to be to be.

I think it's fully functional now.
Let me know if i need to change anything more.

PS: I'll look forward to setup a proper environment to deal with node (actually using vim to edit files is pretty limited)

[cpvalente]

all other options are for hiding custom behaviour, should we keep it here as well? I guess we can just default it to true

[thelan]

Honestly I don't know. Usually I prefer keeping the original behavior and use an option to change it.
User updating the app will probably be surprised that the default format of the timer has changed ?

But if you prefer i can reverse the condition to make it the new default

[cpvalente]

if the variable was to hide, and the default was on, the users wouldnt see a difference.

My suggestion was with the inclination that all the other options are to hide things, so this one is different.

But I guess you may be correct in the idea that it doesnt matter if it is hide / show, what we are doing is changing the default behaviour. In which case your change makes more sense than my proposal. What do you think?

[thelan]

Changing the text and the default value of the option should be nice to have all the option text to do a "hide function" but i struggle with the boolean parser here:
https://github.com/cpvalente/ontime/blob/master/apps/client/src/features/viewers/common/viewUtils.ts#L32-36

When the parameter is absent from the parameters part in url it will be parsed to "false" thus breaking the default value.
I don't know how to fix this so that's why I inverted the logic from "hide" to "show"

[cpvalente]

Thank you @thelan , left some small suggestions and questions for you.

Setting up an environment should be pretty straightforward, you can also use GitHub codespaces in your fork.
If you get into any trouble or the documentation for developers is insufficient please let me know, I would like this to be as easy as possible
https://github.com/cpvalente/ontime/blob/master/DEVELOPMENT.md

[cpvalente]

Thank you @thelan , apologies it took so long.
We have been considering whether we should be looking at cleanup the the options for time formatting altogether, but that wont happen at this time