-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address some issues in am/pm time parsing #998
Conversation
Important Review SkippedReview was skipped due to path filters Files ignored due to path filters (2)
You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Thank you @jwetzell , changes look good. Good job navigating the logic 🍝 We will need a next step to generalise this logic for backend and frontend. Do you mind if I do it? |
@cpvalente all yours! Are you going to want to do that in this branch or should I merge this and let you sort it out at a later time. |
I think we should merge this. All I need to do is to extract the logic and iron out potential mismatches to the backend implementation. I will ask for your review when it is done |
sounds good! |
resolve some oddities with parsing am/pm times like 10am, 12:00pm, 12:00:00am, etc.
closes #994