-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New schedule section for configuration v2 #146
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
==========================================
- Coverage 77.20% 77.09% -0.12%
==========================================
Files 92 93 +1
Lines 9949 10020 +71
==========================================
+ Hits 7681 7724 +43
- Misses 2003 2032 +29
+ Partials 265 264 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
c5d9e18
to
83e3d3f
Compare
83e3d3f
to
653034f
Compare
653034f
to
ac064ef
Compare
ac064ef
to
d09fc4e
Compare
I finally got a bit of time to do some work on the new scheduling configuration. @jkellerer I wanted to discuss a few options before I go further. The way we call resticprofile from the scheduler will have to change. That's because we allow a list of profiles to be part of the schedule (which I think is a good thing anyway). From now I can see two options:
By writing it I realise I like the second option a bit more, but I wanted to have your opinion on it 😉 |
Reading it, intuitively, I also like option 2 more (before reading the last line 😀). So looks like we're on the same page. |
Regarding the name.. I was thinking that it might be something to consider to have kind of cache and/or state storage which might be used for all sorts of things including detecting name changes. While it may not help now, we could use it later to automatically act when name changes are detected (not only in this case). So it may not necessarily be a disadvantage. |
c570a7e
to
7527484
Compare
d5ab1d8
to
12e29b0
Compare
12e29b0
to
2d453a7
Compare
dd8d5f8
to
22b4dc8
Compare
f7f2be9
to
19b598e
Compare
Replaced by #333 |
This PR is adding support for the
schedules
section on the configuration format v2: