-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a run-schedule command #259
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 68.68% 69.85% +1.16%
==========================================
Files 117 118 +1
Lines 11779 11889 +110
==========================================
+ Hits 8090 8304 +214
+ Misses 3305 3195 -110
- Partials 384 390 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
That's great. Had thought as well that such a change would make sense 👍 |
c18b15c
to
415f907
Compare
The same problem I had with schedule-v2 PR arises here again 😞 there's too many changes to introduce in one PR. I'm going to try to split it up nicely again 👍🏻 |
18e1f78
to
e1846c9
Compare
97086b8
to
78a9c7d
Compare
I think it's the 3rd or maybe 4th time I'm refactoring the scheduling layer, it seems like I always manage to make a mess of it 🤣 The idea on this refactoring is to use an intermediary struct Anyway I think I just need to add a bit of documentation now 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it looks good. I have added a few feedbacks and one concern regarding breaking existing v2 configs. I have not yet tried to use it though.
24a6d6d
to
ec09efd
Compare
31729b5
to
d72db8a
Compare
f461ef9
to
6062a7c
Compare
commit 62fc47e Author: Fred <[email protected]> Date: Wed Feb 21 10:10:53 2024 +0000 avoid the file to be checked by the json schema validator commit 911b6d2 Author: Fred <[email protected]> Date: Wed Feb 21 09:57:13 2024 +0000 commit updated mock commit 6062a7c Author: Fred <[email protected]> Date: Wed Feb 21 09:46:58 2024 +0000 Squashed commit of the following: commit f461ef9 Author: Fred <[email protected]> Date: Tue Feb 13 21:22:30 2024 +0000 WIP commit 12ede06 Author: Fred <[email protected]> Date: Sat Feb 10 11:00:07 2024 +0000 create Init method commit d72db8a Author: Fred <[email protected]> Date: Sat Feb 10 10:10:27 2024 +0000 Squashed commit of the following: commit 31729b5 Author: Fred <[email protected]> Date: Sat Feb 10 10:07:30 2024 +0000 allow run-schedule command on v2 format commit bffa06d Author: Fred <[email protected]> Date: Wed Feb 7 21:50:03 2024 +0000 merge ProfileName and Profiles into one Profiles field commit ec09efd Author: Fred <[email protected]> Date: Wed Feb 7 21:05:33 2024 +0000 Squashed commit of the following: commit 24a6d6d Author: Fred <[email protected]> Date: Tue Nov 14 16:51:50 2023 +0000 fix: remove schedule name from arguments commit ffee984 Author: Fred <[email protected]> Date: Tue Nov 14 15:37:48 2023 +0000 fix: add noshow tag to hide schedule options from main section commit e840956 Author: Fred <[email protected]> Date: Sun Nov 12 18:06:50 2023 +0000 docs: add information on run-schedule command commit 4e4bebb Author: Fred <[email protected]> Date: Sun Nov 12 17:15:33 2023 +0000 extract context creation for unit tests commit c7775a4 Author: Fred <[email protected]> Date: Sun Nov 12 12:56:42 2023 +0000 wire up ignore-on-battery and locks from schedule configuration to context commit 329696e Author: Fred <[email protected]> Date: Sat Nov 11 20:14:29 2023 +0000 update crond to support new run-schedule command line commit 78a9c7d Author: Fred <[email protected]> Date: Sat Nov 11 19:34:49 2023 +0000 Squashed commit of the following: commit 97086b8 Author: Fred <[email protected]> Date: Sat Nov 11 18:00:29 2023 +0000 add a default log file on darwin commit ef2469a Author: Fred <[email protected]> Date: Sat Nov 11 15:57:13 2023 +0000 Merge from pass-context-struct commit f650dd4 Author: Fred <[email protected]> Date: Sat Nov 11 15:43:17 2023 +0000 return a new context on each `With` method commit 1157e07 Author: Fred <[email protected]> Date: Sun Nov 5 19:07:33 2023 +0000 add tests commit a3f4919 Author: Fred <[email protected]> Date: Sun Nov 5 18:42:50 2023 +0000 move logTarget to context commit c8b4421 Author: Fred <[email protected]> Date: Sun Nov 5 17:26:24 2023 +0000 refactoring Context struct commit 4144642 Author: Fred <[email protected]> Date: Wed Nov 1 17:15:46 2023 +0000 pass context to own commands and profile runnner
62fc47e
to
e84045e
Compare
Before finishing the new
schedule
section for the configurationv2
, the existing scheduling could benefit from a newrun-schedule
command.This will simplify the command line generated by the scheduler, and avoid re-scheduling when changing the configuration in most cases.
Implementation details:
config.ScheduleConfig
toschedule.Config
Schedule
object between the configuration file and theschedule.Config
objectProgress: