syslog: local syslog and stdout redirection #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@creativeprojects , do you have any concerns with this. It does change previous behaviour in that it now sends command output by default (though #343 allows to control it). On the other hand the previous version was a bit inconsistent since we sent it to log files but not to syslog. |
|
Yeah I'm fine with it 👍🏻 |
jkellerer
force-pushed
the
enh/syslog
branch
4 times, most recently
from
1b19273
to
8c12867
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 70.90% 70.91% +0.01%
==========================================
Files 121 121
Lines 12299 12304 +5
==========================================
+ Hits 8720 8725 +5
Misses 3185 3185
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Marked it ready for a final review, manually tested all options. |
creativeprojects
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #343, this PR adds local syslog server and command output redirection into syslog.
Motivation: Currently I redirect systemd output to syslog (including all stdout/err from resticprofile). This PR allows to have the same support using the built-in syslog client, which has the advantage of more consistent timestamps (not duplicated in stdout formatted log).
The following additional log URLs are added:
syslog:(local syslog server via unix socket)syslog://hostname(udp on default port 514)syslog://hostname:514(udp on port 514)syslog-tcp://hostname(tcp on default port 514)syslog-tcp://hostname:514(tcp on port 514)