Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object parameter type #691

Merged
merged 8 commits into from
Feb 25, 2020
Merged

object parameter type #691

merged 8 commits into from
Feb 25, 2020

Conversation

yohm
Copy link
Member

@yohm yohm commented Feb 22, 2020

Add a new parameter type "Object". Parameters are specified by JSON object.

image
image

@yohm yohm added this to the v3.8.0 milestone Feb 22, 2020
@yohm yohm self-assigned this Feb 22, 2020
@takeshi-uchitane
Copy link
Contributor

@yohm コード確認しました.タイプをJSONではなくObjectとしたのはなぜでしょうか?
JSONと表記してもらった方がユーザーの混乱が少ない気がします.

@takeshi-uchitane
Copy link
Contributor

takeshi-uchitane commented Feb 25, 2020

並が違うだけで内容は同じJSONをユニークと認識しないが良いか?
oacis_same_object

@yohm
Copy link
Member Author

yohm commented Feb 25, 2020

レビューありがとうございます。
JSONはあくまでフォーマットの名前なので型の名前としては"Object"の方が適切だと思います。

並びが違うのを異なるObjectとして認識してしまうのはMongoDBの仕様です。並びが違っても同一性を判定した方がよいのか微妙なところですが、実装が大変なのでこのままにしておきます。
https://docs.mongodb.com/manual/reference/operator/query/eq/#match-a-document-value

@yohm yohm merged commit 42739ac into develop Feb 25, 2020
@yohm yohm deleted the object_parameter_type branch February 25, 2020 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants