Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto refresh tools in Progress tab #723

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

kimurabps
Copy link
Collaborator

@kimurabps kimurabps commented Jan 13, 2021

refs #719

対応内容

SimulatorページのProgress タブにおいて、auto reloadのチェックがONの時、Number of Runs 及びProgress Overviewのグラフがリアルタイムで更新されるようにしました。

Screen Cast 2021-01-12 at 3 59 44 PM

以下の要件については、#717 がマージされ次第、Runの数押下でRunsタブに遷移するような対応を入れる予定です

それぞれの対応するステータスを持つRun のリストの一覧を表示できるようにすること。

@@ -1,29 +1,29 @@
function setupRefreshTools(table, lengthDiv) {
lengthDiv.append(
function setupRefreshTools(toolsDiv, callback) {
Copy link
Collaborator Author

@kimurabps kimurabps Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

更新処理をcallbackとして渡すようにし、DataTable以外も更新できるような汎用的な関数にしました。もし問題があればご指摘ください 🙇

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらの実装はきれいですね。ありがとうございます。

@kimurabps kimurabps requested a review from yohm January 13, 2021 07:10
@yohm yohm merged commit 9e57015 into develop Jan 13, 2021
@yohm
Copy link
Member

yohm commented Jan 13, 2021

@kimurabps ありがとうございました。コードも動作も確認しました

@yohm yohm deleted the feature/add_auto_refresh_tools_in_progress_tab branch January 13, 2021 23:47
@yohm yohm added this to the Improvement-202103 milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants