Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Files tab in Parameter Set page #724

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

kimurabps
Copy link
Collaborator

@kimurabps kimurabps commented Jan 21, 2021

refs #718

初期表示

初期表示

ファイルを選択して[Show]ボタン押下で該当ファイルを一覧表示

画像の場合
画像の場合

画像ではない場合
画像ではない場合

[Download all]ボタン押下でファイルをzipに固めてダウンロード

download_all

zip

※ファイル名が被らないように頭に #{run_id}_ を付加

Gemfile Show resolved Hide resolved
@kimurabps kimurabps marked this pull request as ready for review January 21, 2021 10:34
@kimurabps kimurabps force-pushed the feature/add_files_tab_in_parameter_set_page branch from 158ad41 to 4dab0ab Compare January 21, 2021 10:39
@kimurabps kimurabps force-pushed the feature/add_files_tab_in_parameter_set_page branch from 4dab0ab to dc6d760 Compare January 21, 2021 10:50
@kimurabps kimurabps requested a review from yohm January 21, 2021 10:52
Copy link
Member

@yohm yohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コードも確認しました。ありがとうございます。
URLも変更されるので戻るボタンで元のページに戻れるのが地味にありがたいです。

@yohm yohm merged commit f4114d3 into develop Jan 22, 2021
@yohm yohm deleted the feature/add_files_tab_in_parameter_set_page branch January 22, 2021 01:51
@yohm yohm added this to the Improvement-202103 milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants