Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit function for filter #727

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Conversation

yusiro-bps
Copy link
Collaborator

@yusiro-bps yusiro-bps commented Jan 27, 2021

refs: #715

ParameterSet のテーブルにおけるフィルターを編集できるようにしました。

Untitled

Validation

フィルター名が空欄の場合

image

フィルター名が他と重複している場合

image

条件の値が空欄の場合

image

flash[:alert] = "Failed to update Filter: #{filter.errors.messages}"
end

redirect_back(fallback_location: simulator)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

検索条件などあれば引き継ぐようにしています。

@yusiro-bps yusiro-bps requested a review from yohm January 27, 2021 06:39
Copy link
Member

@yohm yohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上の画像のように検索条件が2つ(benefit==3, Nsigma==100) あるときに編集ボタンを押すと、下の画像のように一つの条件しか出てきません。すべての検索条件が出るようにしていただけないでしょうか?

Screen Shot 2021-01-28 at 11 06 59

Screen Shot 2021-01-28 at 11 08 06


実はプラスアイコンをクリックすると検索条件が追加できます。(わかりづらくてすみません。。。)
Screen Shot 2021-01-28 at 11 24 23

@yusiro-bps
Copy link
Collaborator Author

ご指摘ありがとうございます。

以下、対応しました。

  • 全ての条件を更新できるようにする
  • 条件を追加できる
  • 条件を削除できる

Untitled

@yusiro-bps yusiro-bps requested a review from yohm January 28, 2021 07:00
Copy link
Member

@yohm yohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございました!

@yohm yohm merged commit f8c8b2d into develop Jan 29, 2021
@yohm yohm deleted the feature/improve_filter_in_parameter_sets branch January 29, 2021 03:04
@yohm yohm added this to the Improvement-202103 milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants