Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selections of 50, 100 for the number of simulation runs #751

Merged
merged 2 commits into from
Jul 17, 2022

Conversation

masanorihirano
Copy link
Contributor

In some simulations, a bigger number of runs of simulations are required to reduce the deviations. Currently, the maximum number of runs is set to 20. But, this PR extends it to 1000.

@yohm
Copy link
Member

yohm commented Jul 17, 2022

Thank you for your pull requests. Currently, we intentionally limit the number of runs so that it does not take an excessively long time to make runs. Since 1000 sounds too large, I suggest adding 50&100, instead of 100 & 1000. Could you make changes?

FYI, if you would like to make an even larger number of jobs, it might be more convenient for you to use command line interfaces (CLIs). CLI command appears at the bottom of the page. You can change "num_runs" in the command to an arbitrary number.

Screen Shot 2022-07-17 at 13 18 47

@yohm yohm self-assigned this Jul 17, 2022
@masanorihirano
Copy link
Contributor Author

Thank you for the reply.
I knew the CLI. Because I have used OACIS for a few years and CLI command did not appear on the WEB in the earlier version, I have used OACIS with this modification.
(Web interface is more useful than CLI because we can check and run using smartphones or tablets)
However, I can understand why you limited the maximum number of runs. So, I made modified PR.

Of curse, on the current version of OACIS, it is easy to run a bigger number of simulations using CLI owing to the CLI command suggestion on the Web interface.
Thus, this PR is not mandatory. But, if possible, please consider marge this modification.

@masanorihirano masanorihirano changed the title Add selections of 100, 1000 for the number of simulation runs Add selections of 50, 100 for the number of simulation runs Jul 17, 2022
@yohm yohm merged commit 37f1fb3 into crest-cassia:develop Jul 17, 2022
@yohm
Copy link
Member

yohm commented Jul 17, 2022

@masanorihirano Your PR was merged!

@yohm yohm added this to the v3.10.2 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants