-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isomorphic content API utilities #271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospassos
requested review from
georgekaran,
renan628,
tiagobarros01 and
denis-rossati
April 28, 2024 19:06
9 tasks
Fryuni
requested changes
Apr 29, 2024
georgekaran
previously approved these changes
Apr 29, 2024
renan628
previously approved these changes
Apr 29, 2024
renan628
reviewed
Apr 29, 2024
tiagobarros01
previously approved these changes
Apr 29, 2024
denis-rossati
previously approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further to everyone's comments, lgtm
irangarcia
previously approved these changes
May 6, 2024
Fryuni
requested changes
May 6, 2024
marcospassos
dismissed stale reviews from irangarcia, denis-rossati, tiagobarros01, renan628, and georgekaran
via
May 6, 2024 15:49
be296a9
Fryuni
previously approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice
denis-rossati
previously approved these changes
May 6, 2024
Co-authored-by: Denis Rossati <[email protected]>
renan628
previously approved these changes
May 6, 2024
denis-rossati
previously approved these changes
May 6, 2024
Fryuni
previously approved these changes
May 6, 2024
marcospassos
dismissed stale reviews from Fryuni, denis-rossati, and renan628
via
May 6, 2024 15:57
1524c60
Fryuni
approved these changes
May 6, 2024
renan628
reviewed
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces the low-level content APIs that were originally added to the
plug-react
library, but due to its broad scope, it makes more sense to belong to theplug-js
, which is the foundation library for all Javascript-based projects.The API changes slightly from the original implementation – which was intended for server-side only – to support both client and server-side requests as this better aligns with this library scope.
Checklist