Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isomorphic content API utilities #271

Merged
merged 6 commits into from
May 6, 2024
Merged

Add isomorphic content API utilities #271

merged 6 commits into from
May 6, 2024

Conversation

marcospassos
Copy link
Member

@marcospassos marcospassos commented Apr 28, 2024

Summary

This pull request introduces the low-level content APIs that were originally added to the plug-react library, but due to its broad scope, it makes more sense to belong to the plug-js, which is the foundation library for all Javascript-based projects.

The API changes slightly from the original implementation – which was intended for server-side only – to support both client and server-side requests as this better aligns with this library scope.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

src/api/fetchContent.ts Outdated Show resolved Hide resolved
src/api/evaluate.ts Outdated Show resolved Hide resolved
georgekaran
georgekaran previously approved these changes Apr 29, 2024
renan628
renan628 previously approved these changes Apr 29, 2024
test/api/evaluate.test.ts Outdated Show resolved Hide resolved
tiagobarros01
tiagobarros01 previously approved these changes Apr 29, 2024
denis-rossati
denis-rossati previously approved these changes Apr 29, 2024
Copy link
Member

@denis-rossati denis-rossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further to everyone's comments, lgtm

irangarcia
irangarcia previously approved these changes May 6, 2024
src/api/evaluate.ts Outdated Show resolved Hide resolved
src/api/fetchContent.ts Outdated Show resolved Hide resolved
Fryuni
Fryuni previously approved these changes May 6, 2024
Copy link
Member

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

denis-rossati
denis-rossati previously approved these changes May 6, 2024
test/plug.test.ts Outdated Show resolved Hide resolved
Co-authored-by: Denis Rossati <[email protected]>
renan628
renan628 previously approved these changes May 6, 2024
denis-rossati
denis-rossati previously approved these changes May 6, 2024
Fryuni
Fryuni previously approved these changes May 6, 2024
@marcospassos marcospassos dismissed stale reviews from Fryuni, denis-rossati, and renan628 via 1524c60 May 6, 2024 15:57
@marcospassos marcospassos merged commit 8ed066d into master May 6, 2024
8 checks passed
@marcospassos marcospassos deleted the api branch May 6, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants