Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixing errors and patterns #16

Merged
merged 2 commits into from
Jun 21, 2021
Merged

docs: Fixing errors and patterns #16

merged 2 commits into from
Jun 21, 2021

Conversation

GabrielBarcelos1
Copy link
Contributor

@GabrielBarcelos1 GabrielBarcelos1 commented Jun 21, 2021

Summary

  • Removing unnecessary React import
  • Adding Suspense in parts it was used
  • Removing Fragment in parts it wasn't used
  • fixing import order so that a pattern is maintained throughout the documentation

Resolve: none issue

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

- Removing unnecessary React import
- Adding Suspense in parts it was used
- Removing Fragment in parts it wasn't used
-fixing import order so that a pattern is maintained throughout the documentation

Resolve: none issue
@marcospassos
Copy link
Member

Thank you for your collaboration, @GabrielBarcelos1! Can you remove the yarn.lock from your commit? Everything else looks good to me.

@marcospassos marcospassos added the documentation Improvements or additions to documentation label Jun 21, 2021
@GabrielBarcelos1
Copy link
Contributor Author

It's done 😀

Copy link
Member

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fryuni
Copy link
Member

Fryuni commented Jun 21, 2021

@marcospassos I fixed the security checks on master already so I'll merge this 😄

@Fryuni Fryuni merged commit d92035c into croct-tech:master Jun 21, 2021
@marcospassos
Copy link
Member

Thank you, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants