-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datatype module support to make Jackson recognize Java 8 Date & Time #551
Conversation
…API data types (JSR-310)
great, thanks for contributing! this change looks straight forward and good - however, the CI fails for some tools/SDK issues .. not sure what's the matter .. |
I think we should try a restart of the CI first. |
Following this
It looks like your CI-pipeline uses Java 11 (major Java version = 55) for compiling class com/android/prefs/AndroidLocationsProvider, and then CI-pipeline try to run compiled code using Java 8 (major Java version = 52). Maybe it helps - https://www.baeldung.com/java-lang-unsupportedclassversion |
Here is issue from android-actions repo. There is no problem solving. But people say, that it happens sporadically. So maybe restart of the CI can help. If you can, try to restart please |
fwiw, I've restarted this PR's CI jobs, lets see. I think this needs update to grab "the new" java thing for running this CI https://github.com/crossbario/autobahn-java/blob/master/.github/workflows/main.yml |
Hi! I fix the pipeline in my fork! The problem was in Java version. This action 'android-actions/setup-android@v2' installs Android SDK. And it requires Java 11 at the environment. Unfortunately, I can't find why it requires Java 11. May be there are some changes in 'android-actions/setup-android@v2' or in the Android SDK. I have changed the java version in pipeline from 8 to 11 and it works. There is a result of running this pipeline in my fork - succeeded: https://github.com/pavelvic/autobahn-java/actions/runs/6564538141/job/17831094583 |
So, do you still need this feature? Or should I close this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good
@pavelvic sorry for the delay, merged. thanks for contributing! |
Hi! There is no feature for parsing Java 8 Date & Time formats.
IIf we try to deserialize string obj "2023-10-06T18:29:50.138+03:00" to object of class OffsetDateTime, we have the exception "com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Java 8 date/time type
java.time.OffsetDateTime
not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling".So this PR add this feature to your wonderful library