allow passing reader to read metadata #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
aduffeck
approved these changes
May 12, 2023
This was referenced May 15, 2023
9 tasks
2403905
pushed a commit
to 2403905/reva
that referenced
this pull request
May 19, 2023
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now pass a Reader for the locked file to lower level functions so metadata can be read without aquiring a new file lock.
Yet another Alternative to #3880
Less magic approach than #3885