Add Metadata to lock

[kobergj]

Adds ownername and locktime to the lock information

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[glpatcern]

@kobergj FWIW the Lock object already features the owner as a user object, and the expiration as opposed to the lock time because at the time we agreed it's better to directly encode the expiration time. Are you sure you need to encode those extra properties as opaque parameters?

[kobergj]

@glpatcern it only contains the ownerID. Web would need to make another call to get the user name. Also we need the lock time to show since when the file is locked.

Both values are only needed for the client. That's why I encoded them in the opaque. The server doesn't really need them.

This was the simplest solution how to get this values to the client that I could come up with. I'm happy to implement another solution if you have an idea.

[butonic]

change the xml namespace, pls

[butonic]

In general I would also prefer if web would cache more information like user displaynames ... they rarely change. With the graph api we can fine tune these requests ... but not part of this PR...

[glpatcern]

I see, thanks. For the username I guess it's fine as it's essentially an optimization. For the lock time, I'd challenge the usefulness of that information, also considering that wopi apps often recreate locks (UnlockAndRelock in the WOPI API), therefore the lock time keeps being pushed forward. Same reasoning applies to the expiration of course, but IMHO it's better to know that "the lock may expire in x minutes with no activity" rather than "the lock was created x minutes ago".

[kobergj]

Yeah, that is actually a good point. But not for me to decide unfortunately. @tbsbdr is that something we want to consider? Showing lock expiration time instead of lock creation time?

[tbsbdr]

Showing lock expiration time is totally fine for me 👍