Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework hidden shares #4256

Merged
merged 12 commits into from
Oct 24, 2023
Merged

Conversation

dragonchaser
Copy link

@dragonchaser dragonchaser commented Oct 13, 2023

Enhancement: Rename hidden share variable name

We have renamed the hidden flag on shares from Hide -> Hidden to align to the cs3api

see cs3org/cs3apis#214

@update-docs
Copy link

update-docs bot commented Oct 13, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragonchaser dragonchaser force-pushed the rework-hidden-shares branch 2 times, most recently from 875bd2b to 832157f Compare October 18, 2023 11:42
@dragonchaser dragonchaser force-pushed the rework-hidden-shares branch 4 times, most recently from 9230cef to f844896 Compare October 20, 2023 09:36
@dragonchaser dragonchaser marked this pull request as ready for review October 20, 2023 09:52
@dragonchaser dragonchaser changed the title [WIP] Rework hidden shares Rework hidden shares Oct 20, 2023
dragonchaser and others added 10 commits October 23, 2023 15:37
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Co-authored-by: André Duffeck <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Co-authored-by: Julian Koberg <[email protected]>

Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser dragonchaser merged commit ee81e3d into cs3org:edge Oct 24, 2023
9 checks passed
@dragonchaser dragonchaser deleted the rework-hidden-shares branch October 24, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants