Fix concurrency issue when listing received shares #4267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
aduffeck
force-pushed
the
fix-listing-received-shares
branch
from
07ffaed
to
4f278f8
Compare
aduffeck
changed the title
kobergj
approved these changes
Oct 18, 2023
kobergj
requested changes
Oct 18, 2023
kobergj
approved these changes
Oct 18, 2023
|
@aduffeck is there a issue / other source that describes the symptoms? I know a few support cases that are related to share creation / listing and would like to know if one of them is fixed by this PR. |
|
@wkloucek no, I don't think there's an issue for that. The problem was that the CI pipelines started to flake after turning on the auto-acceptance of shares. Retrieving the list of received shares while also creating shares for that user could run into concurrency issues and panic. Not sure how likely it is to trigger that in real-world scenarios... |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a concurrency issue when listing received shares.