Fix http verb #4299
Merged
Fix http verb #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
approved these changes
Oct 30, 2023
|
The change surely makes sense (the original action was meant to generate a token without storing it), yet this endpoint is consumed by the ScienceMesh web app, so such change needs to be coordinated with the frontend - and eventually propagated to Reva master. What are your thoughts concerning the ScienceMesh web app? |
|
Also, the Nextcloud/OC10 app needs to be update accordingly to use the new verb |
|
I will talk to the web team regarding their plans and how to adapt to this change. I'll go ahead and merge this nonetheless for now in order to get a clean start in edge if possible. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the HTTP verb of the /generate-invite endpoint of the sciencemesh service to POST as it clearly has side effects for the system, it's not just a read-only call.