-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing ng preparation and bugfix #4335
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
4315f6b
to
95fb82b
Compare
b00ec74
to
df275c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy path looks good to me, i just found one case with a potential panic.
df275c0
to
3d7572e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGT 🚀
Description
Usage
@rhafer @fschade
I think we can use that helper function to calculate the available permissions.
Please let me know if you see a more elegant way without reflection 😄