Skip unnecessary share retrieval #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
changed the title
butonic
force-pushed
the
skip-unnecessary-received-share-retrieval
branch
3 times, most recently
from
e971c10
to
eff0eec
Compare
kobergj
requested changes
Jan 9, 2024
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/pending.go
Show resolved
Hide resolved
Signed-off-by: Jörn Friedrich Dreyer <[email protected]> fix typo Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
skip-unnecessary-received-share-retrieval
branch
from
19b6b46
to
9ae6877
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
commented
Jan 10, 2024
| } | ||
| updateMask := &fieldmaskpb.FieldMask{Paths: []string{"state", "hidden"}} | ||
| updateMask := &fieldmaskpb.FieldMask{Paths: []string{"state"}} |
There was a problem hiding this comment.
we need to make sure the share managers respect the field mask!
There was a problem hiding this comment.
jsonsc3 handles it, memory handles it, owncloudsql handles it (but does not know anything about the hidden flag), json handles it (but does not know anything about the hidden flag), cs3 also has it but does not know anything about the hidden flag). good to merge
kobergj
approved these changes
Jan 10, 2024
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
skip-unnecessary-received-share-retrieval
branch
from
78ed0c0
to
5a60236
Compare
kobergj
approved these changes
Jan 10, 2024
dragonchaser
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT we already got a list of all reveiced shares, including the Hidden flag. No need to make another GetReceivedShare request for every accepted share.