-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
writer-sarif: add descriptions for ShellCheck rules #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, This is great! Thank you @lzaoral
tested in - redhat-plumbers-in-action/differential-shellcheck#371
EDIT:
For reference, this is the behavior before this PR
@jamacku I cannot see the |
@kdudka Yes, you have to have access to the Security dashboard of the project in order to see those links. I think you need at least write access to the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indeed improves the way how GitHub renders the findings.
475a66a
to
a2a4ad1
Compare
No description provided.