Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faraday 0.9 compatibility (vcr source from master) #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DraCzris
Copy link

@DraCzris DraCzris commented Mar 5, 2015

separate branch for this issue.

IMHO the fault is on vcr's side. The fix was merged to master in October 2014, but no tagged version was released since September 2014.

I've found a workaround in moving the vcr from kosapi_client.gemspec to Gemfile and use master branch (maybe lock commit sha) as gem 'vcr', github: 'vcr/vcr', branch: 'master'. It's not a nice one, but once again isn't vcr just a development (testing) dependency?

#8 (comment)

@jnv
Copy link
Contributor

jnv commented Mar 5, 2015

Thanks, I think this is the best solution; for development purpose you Bundler anyway.

However, vcr should be present only in the test group, development group is not installed in the CI.

gem 'vcr', github: 'vcr/vcr', branch: 'master', group: :test

I think the CIs are failing due to a secured access tokens (they're not available for PR builds). Could you please verify that tests pass with new VCR?

@DraCzris
Copy link
Author

DraCzris commented Mar 5, 2015

After changes:

screen shot 2015-03-05 at 17 11 53

Some of them fails before my changes beeing applied:

screen shot 2015-03-05 at 17 15 27

Also in #10 I've fixed all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants