Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto reajust scrollview subviews y value #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Auto reajust scrollview subviews y value #4

wants to merge 1 commit into from

Conversation

andrefmsilva
Copy link

with this we can add views direct in xib and they will reajust when image is added

@cyndibaby905
Copy link
Owner

Hi @Zasuk , thanks for your contribution:) But I have to say may be I won't accept this pull request. Yes, when using TwitterCover, the content of UIScrollView should begin at CGPointMake(0,CHTwitterCoverViewHeight) instead of CGPointZero, since the area CGRectMake(0,0,self.width,CHTwitterCoverViewHeight) is reserved for TwitterCover, your code highlighted this, which is good. But I think this adjustment should be outside UIScrollView itself, since addSubView can happen in anywhere. May be UIViewController is a better place to do this adjustment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants