feat: env to use path params in download url (#19526)

* feat: env to use path params in download url * feat: change env to url template * feat: fix snapshot Co-authored-by: Matt Henkes <[email protected]>
cypress-io · Jan 18, 2022 · 2685f82 · 2685f82 · cypress-bot · Jan 18, 2022
1 parent 3b23887
commit 2685f82
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/cli/__snapshots__/download_spec.js b/cli/__snapshots__/download_spec.js
@@ -40,3 +40,7 @@ https://download.cypress.io/desktop?platform=OS&arch=ARCH
 exports['specific version desktop url 1'] = `
 https://download.cypress.io/desktop/0.20.2?platform=OS&arch=ARCH
 `
+
+exports['desktop url from template'] = `
+https://download.cypress.io/desktop/0.20.2/darwin-x64/cypress.zip
+`
diff --git a/cli/lib/tasks/download.js b/cli/lib/tasks/download.js
@@ -64,8 +64,11 @@ const getCA = () => {
 const prepend = (urlPath) => {
   const endpoint = Url.resolve(getBaseUrl(), urlPath)
   const platform = os.platform()
+  const pathTemplate = util.getEnv('CYPRESS_DOWNLOAD_PATH_TEMPLATE')
 
-  return `${endpoint}?platform=${platform}&arch=${arch()}`
+  return pathTemplate
+    ? pathTemplate.replace('${endpoint}', endpoint).replace('${platform}', platform).replace('${arch}', arch())
+    : `${endpoint}?platform=${platform}&arch=${arch()}`
 }
 
 const getUrl = (version) => {

diff --git a/cli/test/lib/tasks/download_spec.js b/cli/test/lib/tasks/download_spec.js
@@ -65,6 +65,13 @@ describe('lib/tasks/download', function () {
       snapshot('specific version desktop url 1', normalize(url))
     })
 
+    it('returns custom url from template', () => {
+      process.env.CYPRESS_DOWNLOAD_PATH_TEMPLATE = '${endpoint}/${platform}-${arch}/cypress.zip'
+      const url = download.getUrl('0.20.2')
+
+      snapshot('desktop url from template', normalize(url))
+    })
+
     it('returns input if it is already an https link', () => {
       const url = 'https://somewhere.com'
       const result = download.getUrl(url)