Skip to content

Commit

Permalink
fix: fix UI flash when switching to debug page (#26761)
Browse files Browse the repository at this point in the history
  • Loading branch information
warrensplayer committed May 17, 2023
1 parent dc80641 commit 7fa5103
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ _Released 05/23/2023 (PENDING)_
- Reverted [#26452](https://github.com/cypress-io/cypress/pull/26630) which introduced a bug that prevents users from using End to End with Yarn 3. Fixed in [#26735](https://github.com/cypress-io/cypress/pull/26735). Fixes [#26676](https://github.com/cypress-io/cypress/issues/26676).
- Moved `types` condition to the front of `package.json#exports` since keys there are meant to be order-sensitive. Fixed in [#26630](https://github.com/cypress-io/cypress/pull/26630).
- Fixed an issue where newly-installed dependencies would not be detected during Component Testing setup. Addresses [#26685](https://github.com/cypress-io/cypress/issues/26685).
- Fixed a UI regression that was flashing an "empty" state inappropriately when loading the Debug page. Fixed in [#26761](https://github.com/cypress-io/cypress/pull/26761).

**Misc:**

Expand Down
3 changes: 1 addition & 2 deletions packages/app/src/pages/Debug.vue
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const cachedProject = ref<DebugSpecsFragment>()
const query = useQuery({ query: DebugDocument, variables, pause: shouldPauseQuery, requestPolicy: 'network-only' })
const isLoading = computed(() => {
const relevantRunsHaveNotLoaded = !relevantRuns.value
const relevantRunsHaveNotLoaded = !relevantRuns.value.all
const queryIsBeingFetched = query.fetching.value
const cloudProject = query.data.value?.currentProject?.cloudProject?.__typename === 'CloudProject'
Expand All @@ -76,7 +76,6 @@ const isLoading = computed(() => {
})
watchEffect(() => {
//console.log('query for debug', query.data.value, relevantRuns.value.commitShas)
if (query.data.value?.currentProject?.cloudProject?.__typename === 'CloudProject') {
const cloudProject = query.data.value.currentProject.cloudProject
Expand Down

5 comments on commit 7fa5103

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 7fa5103 May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.12.1/linux-arm64/develop-7fa5103f6734680df900ff9c071bbe1ef51a86d9/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 7fa5103 May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.12.1/linux-x64/develop-7fa5103f6734680df900ff9c071bbe1ef51a86d9/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 7fa5103 May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.12.1/darwin-arm64/develop-7fa5103f6734680df900ff9c071bbe1ef51a86d9/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 7fa5103 May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.12.1/darwin-x64/develop-7fa5103f6734680df900ff9c071bbe1ef51a86d9/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 7fa5103 May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.12.1/win32-x64/develop-7fa5103f6734680df900ff9c071bbe1ef51a86d9/cypress.tgz

Please sign in to comment.