fix: surface openSSL unhandled rejection errors that occur within plu…

…gin code (#19553)

Co-authored-by: Matt Henkes <[email protected]>

packages/server/lib/plugins/child/browser_launch.js

@@ -8,7 +8,7 @@ module.exports = {
     // TODO: remove in next breaking release
     // This will send a warning message when a deprecated API is used
     // define array-like functions on this object so we can warn about using deprecated array API
-    // while still fufiling desired behavior
+    // while still fulfilling desired behavior
     const [, launchOptions] = args
 
     let hasEmittedWarning = false

packages/server/lib/plugins/child/run_plugins.js

@@ -155,9 +155,16 @@ const runPlugins = (ipc, pluginsFile, projectRoot) => {
   })
 
   process.on('unhandledRejection', (event) => {
-    const err = (event && event.reason) || event
+    let err = event
+
+    debug('unhandled rejection:', event)
+
+    // Rejected Bluebird promises will return a reason object.
+    // OpenSSL error returns a reason as user-friendly string.
+    if (event && event.reason && typeof event.reason === 'object') {
+      err = event.reason
+    }
 
-    debug('unhandled rejection:', util.serializeError(err))
     ipc.send('error', util.serializeError(err))
 
     return false

packages/server/test/unit/plugins/child/run_plugins_spec.js

@@ -408,10 +408,16 @@ describe('lib/plugins/child/run_plugins', () => {
       expect(this.ipc.send).to.be.calledWith('error', this.err)
     })
 
-    it('sends the serialized reason via ipc on process unhandledRejection', function () {
+    it('sends the serialized Bluebird error via ipc on process unhandledRejection', function () {
       process.on.withArgs('unhandledRejection').yield({ reason: this.err })
 
       expect(this.ipc.send).to.be.calledWith('error', this.err)
     })
+
+    it('sends the serialized OpenSSL error via ipc on process unhandledRejection', function () {
+      process.on.withArgs('unhandledRejection').yield({ ...this.err, reason: 'reason' })
+
+      expect(this.ipc.send).to.be.calledWith('error', this.err)
+    })
   })
 })