Skip to content

Commit

Permalink
chore: fix windows CI regressions (#27001)
Browse files Browse the repository at this point in the history
* chore: fix flaky windows tests

* add windows to CI

* try windows again
  • Loading branch information
lmiller1990 committed Jun 12, 2023
1 parent 0d26b0f commit be12245
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ mainBuildFilters: &mainBuildFilters
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- 'update-v8-snapshot-cache-on-develop'
- 'matth/feat/chrome-headless'
- 'lmiller/fix-windows-regressions'

# usually we don't build Mac app - it takes a long time
# but sometimes we want to really confirm we are doing the right thing
Expand Down Expand Up @@ -73,6 +74,7 @@ windowsWorkflowFilters: &windows-workflow-filters
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'matth/feat/chrome-headless', << pipeline.git.branch >> ]
- equal: [ 'lmiller/fix-windows-regressions', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand Down Expand Up @@ -139,7 +141,7 @@ commands:
- run:
name: Check current branch to persist artifacts
command: |
if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "update-v8-snapshot-cache-on-develop" && "$CIRCLE_BRANCH" != "matth/chore/add-telemetry-realworld-app" ]]; then
if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "update-v8-snapshot-cache-on-develop" && "$CIRCLE_BRANCH" != "lmiller/fix-windows-regressions" ]]; then
echo "Not uploading artifacts or posting install comment for this branch."
circleci-agent step halt
fi
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import defaultMessages from '@packages/frontend-shared/src/locales/en-US.json'
import pkg from '../../../../package.json'
import { getPathForPlatform } from './support/getPathForPlatform'

const expectStackToBe = (mode: 'open' | 'closed') => {
cy.get(`[data-cy="stack-open-${mode === 'open' ? 'true' : 'false'}"]`)
Expand Down Expand Up @@ -161,7 +162,7 @@ describe('Launchpad: Error System Tests', () => {
cy.findAllByTestId('collapsible').should('be.visible')
cy.contains('h3', 'TSError')
cy.contains('p', 'Your configFile is invalid:')
cy.contains('p', 'cy-projects/config-with-ts-syntax-error/cypress.config.ts')
cy.contains('p', getPathForPlatform('cy-projects/config-with-ts-syntax-error/cypress.config.ts'))
cy.contains('p', 'It threw an error when required, check the stack trace below:')

cy.withCtx(async (ctx) => {
Expand Down Expand Up @@ -207,7 +208,7 @@ describe('Launchpad: Error System Tests', () => {
cy.findAllByTestId('collapsible').should('be.visible')
cy.contains('h3', 'Error')
cy.contains('p', 'Your configFile is invalid:')
cy.contains('p', 'cy-projects/config-with-import-error/cypress.config.js')
cy.contains('p', getPathForPlatform('cy-projects/config-with-import-error/cypress.config.js'))
cy.contains('p', 'It threw an error when required, check the stack trace below:')

cy.get('[data-testid="error-code-frame"]').should('contain', 'cypress.config.js:3:23')
Expand All @@ -222,7 +223,7 @@ describe('Launchpad: Error System Tests', () => {
cy.findAllByTestId('collapsible').should('be.visible')
cy.contains('h3', 'TSError')
cy.contains('p', 'Your configFile is invalid:')
cy.contains('p', 'cy-projects/config-with-ts-module-error/cypress.config.ts')
cy.contains('p', getPathForPlatform('cy-projects/config-with-ts-module-error/cypress.config.ts'))
cy.contains('p', 'It threw an error when required, check the stack trace below:')
cy.get('[data-testid="error-code-frame"]').should('contain', 'cypress.config.ts:6:10')
})
Expand Down

4 comments on commit be12245

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on be12245 Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.15.0/linux-arm64/develop-be12245636495c4972b5ab76cb664638ed542f4c/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on be12245 Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.15.0/linux-x64/develop-be12245636495c4972b5ab76cb664638ed542f4c/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on be12245 Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.15.0/darwin-x64/develop-be12245636495c4972b5ab76cb664638ed542f4c/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on be12245 Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.15.0/win32-x64/develop-be12245636495c4972b5ab76cb664638ed542f4c/cypress.tgz

Please sign in to comment.