Making runcode work inside Shiny modules #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @daattali ,
these are the changes as discussed in #184 ...
The
id
argument is used in an unusual way here (because the enclosing module UI needs to be passed, instead of creating an identifier for a UI element), so maybe the argument name should be changed to something else to make that clearer?Let me know if this needs more testing or adjustments,
Best,
Max
Here is a minimal example, I wasn't sure whether it should be included in the documentation:
And here is a more involved example that tests out the new possibilities:
runcode
multiple times with different input types, inside and outside modulesreactive
that is local to the module scope