Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding shinyAce? #94

Merged
merged 1 commit into from
Nov 5, 2016
Merged

adding shinyAce? #94

merged 1 commit into from
Nov 5, 2016

Conversation

shabbychef
Copy link
Contributor

Addressing issue #93 , adds shinyAce editor support. I have not tested this yet, though. (ducks)

@daattali
Copy link
Owner

daattali commented Nov 5, 2016

I've never usd shinyace before, what do the vimkeybindings and hotkeys params that you added do? I was thinking since shinyace has so many more optional params, maybe there could be a ... param added to runcodeUI() and those ... would be passed along to shinyace

@shabbychef
Copy link
Contributor Author

hmmm, the vimkeybindings make the editor act like vim. That's somewhat controversial, of course. The hotkeys allow the input to 'fire' when one of the keys is pressed, say F9, which I find more convenient than clicking a button (and mirrors my use of Conque in vim, noted at http://www.gilgamath.com/vim-ide.html). I am not sure if ... is the right way to set up the plumbing here, I leave that to you.

@daattali
Copy link
Owner

daattali commented Nov 5, 2016

I see. I'll accept this PR now so that you can start using it, but I'll leave the issue open because I'm going to want to come back to it later

@daattali daattali merged commit ed9473f into daattali:master Nov 5, 2016
@shabbychef
Copy link
Contributor Author

Another sensible, though annoying alternative, would be to bring all the options of aceEditor into the API of runcodeUI (see https://github.com/trestletech/shinyAce/blob/master/R/ace-editor.R#L61-L67) by name, rather than relying on the implicit ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants