[DA][perf] Avoid recomputing in progress subset #22734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibsondan
reviewed
Jun 26, 2024
Comment on lines
165
to
170
| asset_record | ||
| and stored_cache_value | ||
| and (stored_cache_value.latest_storage_id or 0) | ||
| >= (asset_record.asset_entry.last_materialization_storage_id or 0) | ||
| and stored_cache_value.partitions_def_id | ||
| == partitions_def.get_serializable_unique_identifier(dynamic_partitions_store=self) |
There was a problem hiding this comment.
this is clever but pretty gnarly, maybe should be a separate helper function in the partition_status_cache module?
def is_cached_materialized_subset_up_to_date(asset_record: AssetRecord, parittions_def: PartitionsDefinition, dynamic_partitions_store) {
}
gibsondan
requested changes
Jun 26, 2024
OwenKephart
force-pushed
the
owen/avoid-recomputing-in-progress-subset
branch
from
15e62ec
to
6095a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We have a simple an efficient way of avoiding doing work when the "materialize" subset is fully up-to-date in the partition status cache. Because we don't have an ASSET_MATERIALIZATION_FAILED event, the same cannot be said regarding the in-progress subset.
So if you have any in-progress runs targeting an asset
get_and_update_asset_status_cache_valuewill always be expensive, even if you only care about the "materialized_susbet" value, which is cheap to calculate. This adds a bit of code to avoid updating the entire asset status cache in cases where the materialized_subset is known to be up to date.How I Tested These Changes